Installing/Uninstalling nd_fivestar conflicts with fivestar

Hi,

I ran into problems with installing/uninstalling the ND Fivestar

Problem 1: missing ND Fivestar field in DS Layout pages

* Install fivestar
* Create a few content types
* Edit the content types and enable the fivestar widget (Not the CCK version!!)
* Install DS/ND Contribs
* Enable ND Fivestar
* Go to DS and create a new build mode
* Go to the lay out of your new build mode
* Notice that the Fivestar field is missing

Solution: go to your content types and save them again. (without adjusting the settings) Now the widget will show on the DS Layout page!

Problem 2: uninstalling ND Fivestar

* Uninstall ND Fivestar
* Go to the content types management page
* Click on Edit for a content type
* Check the fivestar fieldset. For each content type where you had the widget enabled, it's now magically disabled. How come?

Cause

ND Fivestar overrules the enable/disable flag variable set by the Fivestar module (i.e. fivestar_) and replaces them with it's own variable (i.e. nd_fivestar_). It needs the adjusted variable to function properly. Thing is: the adjusted variable is only set when you click on 'submit' on the edit content type screen. It doesn't automatically handle settings of already submitted content types.

Moreover, the original variables aren't set back when ND Fivestar is uninstalled. So you lose your enable/disable setting for all your content types all together.

Solution

Implement hook_install and hook_uninstall :-)