If, like me, you keep your variables stored in settings.php files, you can configure CSM to only change the form commit messages but not change the title, e.g. for situations where another module is controlling it already. Right now, if the csm_form_title_LANG_TYPE variable doesn't exist it uses rather useless page title "the default". It would be much better if the page title was not changed if that variable was blank.

CommentFileSizeAuthor
#1 csm-n740614.patch881 bytesdamienmckenna

Comments

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new881 bytes

Here's a patch :)

jim0203’s picture

Status: Needs review » Fixed

Hey Damien,

This was kind of fixed by http://drupal.org/node/734084, but I've worked your patch in as well to cover the "variables in settings.php files" case. Big thanks.

Committed at http://drupal.org/cvs?commit=346708.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

masondib’s picture

Status: Closed (fixed) » Active

Thanks for this module -- just what I was looking for!

Sorry to reopen this issue, but I also have the Node create title overridden from a different module already, and was hoping to use the functionality of this patch but it didn't work out of the box since the Node create form title field is required. In order for this to work, either the value of #required should be changed to FALSE on line 158 of csm.module or, better yet, the module could allow for more flexibility by mimicking the Block title options: "Override the default title for the block. Use <none> to display no title, or leave blank to use the default block title." I haven't looked into the block code enough to do a proper patch, but I can if you think this would be helpful.

Thanks again for a useful module.

jim0203’s picture

Version: 6.x-1.x-dev » 6.x-1.0-alpha6

@masondib - if you're still interested in providing a patch, I'd certainly be interested in seeing it :)

jim0203’s picture

Assigned: Unassigned » jim0203
Status: Active » Fixed

I've reworked the UI so that it is closer to that provided by block.module, as per masondib's suggestion/request. Will be part of the next dev release and will roll into the next alpha/beta release, too.

jim0203’s picture

Status: Fixed » Closed (fixed)

  • Commit 290cd79 on master, 7.x, 7.x-1.x, 6.x-1.x, 2219683 by jim0203:
    #740614 by DamienMcKenna, jim0203: Fixed...
  • Commit 4c30dcb on master, 7.x, 7.x-1.x, 6.x-1.x, 2219683 by jim0203:
    Issue #740614 by DamienMcKenna, masondib: changed the UI for setting the...