Feature requests for vocabulary display [#74156]

Is it just me or has something completely changed with this plugin for 4.7? For example, under 4.6, I created.

category: Services
term: Services.

I then created a page called MyService, that I filed under the Services term, and the menu that taxonomy_context built looked great. It was:

Services
======
*My Service

and if i had put another term under the Servcies category and filed another page under it, it would look like

Services
======
> New Term
* My Service

But for 4.7 the cateogry is showing up both in the breadcrumb and in the menu block. It looks like this:

Services
=======
>Services
>New Term
>New Term2

The breadcrumb is also busted so when I click on "New Term" it reads:
home >> Services >> Services

Basically, there is a "taxonomy/vocabuly/*" link where there never was one before. Plus, there is a

it outputs right before the list and after it! Why would you have a plug in do that? That makes no sense to me.

Also, when I expand one of the terms, it shows the contents of that term, but it shows it under the tother terms for the cateogry. For example, I have page1, page2, and page3 under "New Term". I click on "New Term" and the menu then looks like:

Services
=======
>Services
V New Term
>New Term2
* page1
* page2
* page3

This used to show up under the V New Terms which is the terms it's filed under.

This behavior occurs with 4.7.2. Is this the way the taxonomoy_context plugin is supposed to be working now? I want the old behavior under 4.6 back. =(
I can't upgrade my site until this problem is fixed and my menus look the same as they do under 4.6. Has anyone else seen this? Maybe I'm doing someting wrong, but I just can't believe that the menus should look like this.

Thank you very much for the work you have done on this plugin. It has helped me greatly under 4.6, but the 4.7 implementation I guess maybe I just don't understand. Just watned to submit this so you knew about the issue I have seen. thanks again for your work.

Comments

Comment #1

venkat-rk CreditAttribution: venkat-rk commented 18 July 2006 at 07:52

I am in a somewhat similar predicament as you. I think giving a listing page for the vocabulary is great (remember, drupal never had one before - and still doesn't have- unless you used Mike Carter's now discontinued taxonomy_vocabulary module), but its current implementation in taxonomy_context is completely perplexing and seems to defeat the purpose.

I think the way to go is NOT to show the parent terms and their descriptions on the vocabulary page. Instead, just output the vocabulary description and list the teasers of nodes tagged with *all* the terms in that vocabulary. This makes the vocabulary page kind of like the top-level of a hierarchical section (taxonomy/term/all) and, together with breadcrumb generation that traverses the hierarchy beginning from the vocabulary term (name), goes a long way towards solving the wretchedness involved in using taxonomy for hierarchical structures in drupal.

Instead, what is happening now is that, even if you have just three or four parent terms within a vocab with a small amount of text and even though you turn off display of sub-term info, the display of term info for the parent terms push the node listings from that vocab a long, long way down the page. You CAN'T turn off the term info itself as the text will disappear altogether everywhere, including the taxonomy term pages.

An alternative option would be to make taxonomy_context skip the breadcrumb generation for the vocabulary and instead go straight to the top-level parent term- for example, Home >>Programmes instead of Home >> Programmes Section (vocab) >> Programmes (parent term).

But, this seems hackish and has implications for site architecture as the vocab would be taken out of the hierarchy. It wouldn't work for vocabs with flat terms (as the hierarchical context would be lost) but only for vocabs in which there is at least a simple hierarchy.

Disabling the parent term info display on the vocab page and replacing it with node listings, coupled with printing out the vocab description seems the simpler, more elegant solution. What was missing in Mike Carter's module was that the vocabulary page was not part of the breadcrumb trail. Taxonomy_context for 4.7 gives the breadcrumb, but the other problems listed above detract from an otherwise excellent (automatic nav menu blocks that respect taxonomy term aliases, for instance) piece of code.

Comment #2

rimshot CreditAttribution: rimshot commented 19 July 2006 at 01:39

It's good to hear that I'm not alone in my thoughts for what is going on with this module. After poking around at the code, I think my only recourse is to hack the 4.7 module so it works the way the old 4.6 module worked. I'm a little worried however that I might see other problems on my site down the road, but I guess that's the chance I'll have to take. I don't really understand why so much had to change between the version I was running under 4.6 and the latest version. The 4.6 version was perfect and now it's really a pain.

Under 4.6 I ran:
// $Id: taxonomy_context.module,v 1.36.2.1 2005/06/16 02:48:42 nedjo Exp $

and the version I now am running under 4.7:
// $Id: taxonomy_context.module,v 1.43.2.6 2006/07/15 05:31:41 nedjo Exp $

I've been able to basically replace the:
theme_taxonomy_context_children_list
taxonomy_context_term_children

from the 4.6 versions and for the post part it's starting to work like I how I would expect. Still have some more hacking to do.

Am still wondering why they have to write out <hr> before and after the menu?

Comment #3

venkat-rk CreditAttribution: venkat-rk commented 19 July 2006 at 15:45

Well, I contacted Nedjo and am hoping he will respond.

In desperation, I did the following:

Turned off the taxonomy breadcrumb setting for all content types
Manually built a menu and added links pointing to taxonomy terms
Made the top level term of the vocab, the top level of the menu too, hoping that the breadcrumb would now read Home>>Top level term>>Sub term

No go. When I click on the link to the top level term in the menu block, the breadcrumb still shows Home>>Vocab Name.

What this means is that if someone clicks on the vocab name in the breadcrumb trail, they will be taken to the vocab page with all its listings of term info.

Apparently, even if you merely enable the module and though breadcrumbs may be turned off for the content types, the breadcrumb for the vocab itself will still be generated.

Comment #4

steffen CreditAttribution: steffen commented 21 July 2006 at 22:35

I've been using this module a long time for it's block menu functionality, which I've loved. I absolutely see the above poster's points, and I'm trying to hack together this module for myself so that I can have a menu that will look like:

Vocabulary
- Term 1
- Term 2
-- Subterm 1
- Term 3
-- Node 1 (subnodes of Term 3)
-- Node 2
- Term 4

...etc. Currently the terms are listed first, then the links to nodes underneath the terms. so it will look like all nodes are sub-nodes of the last term in the vocabulary. They should be put within the <li>term <ul><li>node link</li></ul></li> like this so that they are displayed as proper sub menus.

This shouldn't really be a bug report, but a feature request, I believe...

Comment #5

venkat-rk CreditAttribution: venkat-rk commented 27 July 2006 at 05:35

Good news. Nedjo has expressed his willingness to work on some/all of the issues raised in this thread when he finds time.

Comment #6

nedjo

he/him/his

English

CreditAttribution: nedjo commented 17 September 2006 at 18:24

Title:

Expected behavior when using version 4.7?

» Feature requests for vocabulary display

Apologies for the long delay in addressing these issues.

Major changes were made to the module in http://drupal.org/node/64795, and I no longer recognize most of the code :). They were improvements, but apparently some existing functionality was lost or broken.

There are I think two main things raised in this issue.

The first is a set of support and/or feature requests regarding the way vocabularies display, in breadcrumbs and on taxononomy/vocabulary/x pages, and in the contextual block.

The second is one or more bugs in the contextual block. The nodes no longer display in the correct association with their terms. And, perhaps, terms are no longer correctly nested.

I'd like to keep this isue focused on the first, as it's the one that's got the most discussion. I've opened a separate issue for the second, http://drupal.org/node/84659.

Part of this issue is "by design". We introduced vocabulary display in 4.7 and changed the way breadcrumbs and the contextual menu worked.

For most users, this shouldn't cause big problems, but in particular cases it will. In the setup described by rimshot, where there is a vocabulary that has a term with the same name in it, then yes things will look odd. I'd say offhand, change the name of the vocabulary and put other terms in it and you should get something like what you had before.

Beyond that, let's talk more and try to clarify what the desired changes are.

Comment #7

fgm

French

Paris, France

CreditAttribution: fgm commented 17 September 2006 at 19:08

Since http://drupal.org/node/64795 is still in "needs review" status, I'm not sure the version currently available for download is the proper one.

If the latest patch on http://drupal.org/node/64795 hasn't been applied to the CVS download, it *must* be applied before using the modified module: there were various issues with previous versions of the themeability patch.

Comment #8

fgm

French

Paris, France

CreditAttribution: fgm commented 18 September 2006 at 06:12

I thought of it again to night, and I think that to make sure that the behaviour is proper (or not), it would be best to have a specification as to what the module should output by using its builtin themeability themeability functions.

I created a section dedicated to the module on the Audean wiki, because this is simpler to stabilize a spec than using comments on issues. Each aspect of the module has its own specification page.