Everything seems to be setup perfectly but I have no way of submitting a review after intering the information. Am I missing something or is there a missing submit button?

CommentFileSizeAuthor
#1 74162.patch.txt1.33 KBneclimdul

Comments

neclimdul’s picture

neclimdul
He/Him
commented
Component: User interface » Code
Category: support » bug
StatusFileSize
new 74162.patch.txt1.33 KB

Ok, I had a sneaking suspicion that this wasn't me being stupid. After some heavy digging and fighting with fapi I found a little bug. Its hidden in 2 form_alters so its a little bit tricky to find.

1) node.module will remove #submit from the node form if previews are required.
2) userreview always removes #preview from the userreview node form.

This leaves someone that requires previews with no way to submit a review. I've attached a rough patch that I used to work around it. It probably isn't 100% but it seems to be working on my site. It doesn't remove the preview buttom when node is removing the submit button and it makes sure the review area isn't collapsed if it's a preview(it disapearing would probably confuse most users). I'm open for feedback and ideas.

dado’s picture

dado commented

neclimdul,
nice work & nice patch! i committed to HEAD & 4.7 version of userreview.

please report if all looks well or not.
thanks
dado

neclimdul’s picture

neclimdul
He/Him
commented
Status: Active » Fixed

Seems to be working well.

dado’s picture

dado commented
Status: Fixed » Closed (fixed)

thanks