Closed (fixed)
Project:
Taxonomy Access Control
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 Mar 2010 at 15:33 UTC
Updated:
29 Mar 2010 at 15:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
xjmThis is applicable when the user clicks "Save All" on the admin form. In the case of adding or deleting rows on the admin form, node access should always be updated.
Currently, the submit handler checks each row against the initial form state, and if it differs, then the row data are passed on to
taxonomy_access_defaults_update()ortaxonomy_access_grant_update()as appropriate. These functions insert records into the appropriate taxonomy access table and then add nodes affected by that row to the list of nodes to be updated.One option without any refactoring might be to add an additional, optional argument to the two update functions above, say a
$skip_nodesflag:Then, the submit handler could set this flag if the view, update, and delete permissions are unchanged when the user clicks "save all", without affecting anything else.
Comment #2
xjmAttached patch implements the solution described in #1. Seems to work fine; the list of nodes updated is correct in each case.
Comment #3
xjmCommitted to 6.x-1.x-dev:
http://drupal.org/cvs?commit=341668