As requested in the following threads:

I've written a very raw patch which adds a cover page field to the epublish edition form. I'm still working on this to include themeing support, imagecache compatibility, settings on a per publication basis, and views integration, but its a start for now.

Could a few of you review the patch and/or the idea in general and make a comment about whether its suitable to go into the next main epublish version. Note: I'm also one of the co-maintainers, but I'll only commit the changes if the community and jerdiggity agree on the idea.

Patch attached.

Thanks.

CommentFileSizeAuthor
epublish-coverimage_support.patch6.92 KBalexkb

Comments

alexkb’s picture

alexkb commented

Getting Views to support epublish like this ended up getting quite complicated, so we opted for a different approach: have a cover page content type, and then using select_publication have a field to associate the image with the right edition. We then wrote a small patch for select_publication to support accessing this data through views.

jerdiggity’s picture

jerdiggity commented

Hey! Thanks for the info. Should I apply the original patch listed and then the second one? Or just the second one (and skip the first)?

On a side note, while I do very much appreciate and respect the whole

but I'll only commit the changes if the community and jerdiggity agree on the idea.

thing (and I'm being serious -- I really do), the beauty of version control is that in itself: if I/you/we/people/whoever, all the way up to Dries, Gábor, Angie, etc., doesn't like one thing or another that's been committed, since we have control over each version we can always make changes, see diffs, etc. I know you already know that, but I guess the point I'm getting at is... just do it! :)

You may have heard this line before:

It's easier to ask forgiveness than it is to get permission.

"Amazing" Grace Hopper, Ph.D.
Rear Admiral (Former), United States Navy

If it was worth the time it took to write the code, which obviously it was, then it's certainly worth the time to commit it. If nothing else, we can always change it back. ;)

j

alexkb’s picture

alexkb commented

Hey jerdiggity, I like that quote lol! and thanks for the comments.

I would just forget about that first patch for now. I might come back to it again in the future if I learn views handlers more, but not right now.

The second patch, is for the select_publication module - do you have cvs access to that module - if so, yes, please commit it, if its passes your tests, and other QA stuff. Thanks!

sdague’s picture

sdague commented

@alexkb, I've started to put views into the main of epublish, so it might be worth moving the rest of the epublish views support that you put in select_publication into epublish proper.