Privacy issues?

No, it can't be turned off, it's built in that way.

Interesting thing to think about for future releases.

Does anyone else find this a problem?

No there is no privacy issue with the IP details, affiliates would normally be sending the user via their own website and therefore already have access to the IP address information.

I'm not sure what order information you are concerned about, but on my setup affiliates can only see the order id, order total & their commission.

Univate,

Since when the IP saved in your tables are from the referrer?! 8-) It will be from the user visiting the website... I'll check, but I'd be really surprised that you'd take the referrer since someone could have that URL in their favorite/bookmark.

Guys,

The IP address must either be hidden or be truncated. It is very important legally to have that. There are already two states in the US that have legislation in that regard. There are, I'm sure, similar laws in Europe. Maybe Australia has not yet moved forward in that area?

http://en.wikipedia.org/wiki/Internet_privacy

I will provide a patch shortly with 3 levels of IP masking:

1. Show nothing (Except to the Admin who anyway has access to everything)

2. Show the last 1 or 2 numbers (i.e. *.*.1.2 or *.*.*.1)

3. Show everything (for Australians... 8-) and debugging I guess )

I will then check the order data. Showing the product & price is okay. Showing the first name of the customer might be okay (with an option to hide/show that data), but anything more is not (phone #, address, card #...)

Back soon!
Alexis

Okay, there is a patch.

The Admin Settings screen includes a 'radios' with a choice between hide, show 1 or 2 numbers, show all.

Let me know if you'd prefer to handle the "hide" as "do not add that column in the array." At this time, I just added an unset() after the array which I think is not the best way of doing things.

As I was at it, I fixed a couple t() that were missing and the # of columns for the total (so that the table is correct HTML too.)

Note that it is good practice to use $access instead of $user as a function parameter since $user is also a global that cannot be accessed when defined as a parameter.

Thank you.
Alexis

I just checked the "All Orders" and indeed you show the name of the customer. That cannot fly. If the customer is a business, they most certainly do not want to be known by some random affiliate...

I look into a patch where the admin can choose between what you have now, the username (from $user->name) or just User #.

My concern, even with just $user->name is that a customer who auto-generate an account by purchasing something without first registering may again show his/her full name. And that's something in the core...

Note that a site where users cannot see each others account should be taken in account too. Anyway, I'll be back on that one.

Thank you.
Alexis Wilke

AlexisWilke, I've cleaned up your patch a bit (the .user part) and commited it.

As for the customer name, let's just remove it from the user screens (a patch is welcome).
It doesn't really have any purpose anyway.

Also, I'm from Serbia and you didn't mention our internet privacy laws. Oh, wait...

Cheers,
Bojan

I never said the IP address was from the referrer. I said the affiliate(referrer) would have access to the IP address already of users they are referring through from their own sites - the IP address would be in their own server logs, so you are not showing them anything they don't already have access to or can obtain via other means.

Univate,

Good point! Although if I use Blogger or Wordpress and have a link there to your site, I'll never have access to that IP address...

In most cases, it is safer to hide that information by default.

Bojanz,

Isn't Serbia part of Europe yet? 8-)

Thank you.
Alexis

Hi Bojan,

Okay, there the other half. I noticed that the name under Customer for the Commissions looked wrong, and it was. My mistake since I submitted a patch to fix a problem there in the first place... It should have been $commission['uid'] and not $user->uid.

Otherwise, I fixed both tables: All Orders and Commissions. At this point, I don't recall seeing a problem somewhere else... Kenwen, would you have another request on this one?

Otherwise, the t('Unknown') could also be replaced by the name of the Anonymous user since that's what it represents.

Thank you.
Alexis

Looks like you forgot the patch again ;)

It was really late! 8-)

Commited.

Marking this as fixed, if anyone has more ideas, he's free to reopen it...