Hi!
The mailchimp module works great but the use of the "Newsletter" descriptor in various places didn't fit our use case.
Attached is a patch that allows an admin to change the page titles, checkbox labels and page descriptions in case they don't feel "Newsletter(s)" correctly identifies their mailchimp lists.
This was rolled against the 2010-Feb-26 6.x.2.x-dev release.
Be gentle...this is my first real patch!
Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | mailchimp-744030-5-remove-page-var.patch | 1.76 KB | fenstrat |
| #4 | mailchimp.module.newsletterstrings-2.3-correction.patch | 852 bytes | bocaj |
| #2 | mailchimp.module.newsletterstrings-2.3.patch | 9.56 KB | bocaj |
| #1 | mailchimp.module.newsletterstrings.patch | 9.62 KB | krlucas |
| mailchimp.module.newsletterstrings.patch | 8.79 KB | krlucas |
Comments
Comment #1
krlucas commentedwoops. previous patch had the effect of overriding the page title on any page in which the block appeared.
new patch attached.
Comment #2
bocaj commentedI realize that this is old, but I needed this functionality for a project as well.
I rerolled this patch for 2.3. This would be very nice to have included in the next release!
Thanks!
Comment #3
levelos commentedhttp://drupal.org/cvs?commit=468938
Comment #4
bocaj commentedThanks for committing this loubabe...however, I just noticed on our production website (I don't remember this happening while testing) that the page title was being replaced again just as krlucas had pointed out in #1 above regarding the initial patch. This corrected small patch resolves the issue. This is rolled against 2.x-dev.
I have tried it on our production site and all page titles have returned to their expected values. Sorry for not being able to catch this before your previous commit!
Thanks again!
Comment #5
fenstratI've updated the patch from #4 due to the fact that the $page variable is no longer being used at all.
To be honest I'm not entirely sure why the $page variable was introduced in the first place. It appears to be an attempt to ensure the page title is overridden on the user/%uid/mailchimp page but it appears it never worked. It also has the side effect of overwriting the page title on every page where the subscription block is active.
Following up here but this has also been reported in #1041052: Sign-up block makes all page titles 'Newsletter Subscriptions' when logged in
Comment #6
levelos commentedfixed, http://drupal.org/cvs?commit=498154