Download & Extend
Devel » Issues

devel_rebuild_node_comment_statistics() should use n.created not n.changed for nodes without comments

Posted by gpk on March 16, 2010 at 11:26pm
Project:Devel
Version:6.x-1.x-dev
Component:devel
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

In this respect http://api.drupal.org/api/function/comment_enable/6 is wrong, but http://api.drupal.org/api/function/_comment_update_node_statistics/6 has it right.

Note that new nodes without comments have the last_comment_timestamp set to n.changed - which is the same as n.created - and this value is not updated if the node is updated.

This can all lead to incoherently ordered listings on the tracker page.

Also devel 6.x still has the page callback devel_rebuild_node_comment_statistics_page() but the menu item went in 1.248 (http://drupalcode.org/viewvc/drupal/contributions/modules/devel/devel.mo...).

Related: #236511: SQL bug in devel_rebuild_node_comment_statistics.

Login or register to post comments

Comments

#1

Posted by gpk on March 16, 2010 at 11:28pm

I also opened this against core for the bug in comment_enable():
#743804: comment_enable() should use node created time not changed time for last_comment_timestamp

#2

Posted by moshe weitzman on April 3, 2010 at 5:19am
Status:active» fixed

fixed in d6 and d7. thx.

#3

Posted by System Message on April 17, 2010 at 5:20am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.