problem: the smileys block on content submission pages displays the smileys acronyms (":)" ":-)" ":smile:" etc) separated by literal " ", both in the descriptive text beside the smiley and in the images alt and title attributes.
solution: don't check_plain() the descriptive text, and don't add " " to alt and title attributes
patch attached. it also reduces the whitespace between acronyms from 3 to 2, which in my tests with multiple themes is sufficient and doesn't cause linebreaks.
please test, review, and apply. thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| smileys_1.patch | 1.15 KB | ax |
Comments
Comment #1
jbrown commentedworks for me
Comment #2
arne@dbyte.nl commentedYep works nice
Comment #3
rkn-dupe commentedHas this not been committed yet?
Works fine for me, but i just upped my smileys version and this wasnt in yet :(
Comment #4
Gurpartap Singh commentedThis is fixed with Drupal 5.x release of smileys. Though I see less chances putting this into 4.7.x version. If time allows...
Comment #5
(not verified) commented