problem: the smileys block on content submission pages displays the smileys acronyms (":)" ":-)" ":smile:" etc) separated by literal " ", both in the descriptive text beside the smiley and in the images alt and title attributes.

solution: don't check_plain() the descriptive text, and don't add " " to alt and title attributes

patch attached. it also reduces the whitespace between acronyms from 3 to 2, which in my tests with multiple themes is sufficient and doesn't cause linebreaks.

please test, review, and apply. thanks!

CommentFileSizeAuthor
smileys_1.patch1.15 KBax

Comments

jbrown’s picture

Status: Active » Reviewed & tested by the community

works for me

arne@dbyte.nl’s picture

Yep works nice

rkn-dupe’s picture

Has this not been committed yet?

Works fine for me, but i just upped my smileys version and this wasnt in yet :(

Gurpartap Singh’s picture

Version: 4.7.x-1.x-dev » 5.x-1.0
Status: Reviewed & tested by the community » Fixed

This is fixed with Drupal 5.x release of smileys. Though I see less chances putting this into 4.7.x version. If time allows...

Anonymous’s picture

Status: Fixed » Closed (fixed)