Code needs massive standards cleanup

My plan at this point is to knock out the critical bugs/features first and refactor as I go. As I come to features that may require more significant architecture changes we'll assess them at that time. Cleaning up the javascript, however, really is a project unto itself.

OK, here is a mega patch that hits a lot of the styling/standards cleanup. There are a few important notes here though:

1. I changed a number of PHP function names that were using camelCase. I'm pretty sure I cleaned up all of the internal references but if anyone wrote custom code using those functions, their work will break. We should probably add a note to the README or create an UPDATE.txt for tracking the changes in the module where we can flag this for people. If this seems too extreme I can back those changes out and save it for a V3 of the module, but it really would be good to clean this up. (Should also note that the JS files need a similar cleanup in the other direction, but I'll look at that when I get to them.)
2. The OAuth.inc and all JS files have not been done yet, aside from a global white space cleanup I did.
3. I left a lot if "Undocumented XXX" in the comments, which I'll go back and fill in over time, but I wanted to set up the expected standard in case anyone else feels like helping out with that. ;-)

Thanks, add1sun. I've reviewed your changes and committed to dev.

Here is a follow up patch that fixes up the JS standards a bit, fixes a few camel/underscore things I missed, cleans up some more formatting stuff, along with a few WTF? comments. ;-)

Thanks,

Unfortunately I committed a minor change (variable naming problem) after checking in your last patch so this patch is not rolled against the latest version of dev. I'm not going to have time to mess with it right now so if it's important to you that it get checked in before Sunday then I'd love it if you'd re-roll. Otherwise I'll take care of it later. Thanks again!

Never mind :) -- found the time. It's now committed. I made another small change so you'll want to update to the latest dev before rolling any more patches. I'll also start documenting some of the functions as I go.

Woot! Here is another one. We were spitting a ton of PHP notices, which pointed out some oopsies. The biggest line change was moving the constants into the .module file instead of admin.inc because you are using those constants in more than one file now. I also removed the module version constant (and the 2 places it was used, one of which wasn't actually called anywhere) since we'd need to keep remembering to update it manually which is silly. People can see which version they are using in the module admin page.

I'm sure glad I haven't done much coding on this lately, merging would be annoying ;). J/k, in all seriousness, thanks for the patch.

ANy chance we can get this last patch in soon so we don't end up with funky conflicts? I think we can call this closed after this one and any additional cleanups down the road should be in new issues.

Ok, finally got around to committing to dev! Thanks!