I'm using storm for a helpdesk situation and found that staff had no idea what "Storm" meant, so I went through and added the ability to refer to Storm with a different name in the UI.

Notes:
- I have a feeling changing references from Storm to [admin provided alternative string] in the Drupal Permissions list is going to cause issues. So I may need to ditch that portion of my patch. :(
- There was a separate issue in stormticket/stormticket.views.inc where ticket was misspelled "ticet". This is included, but I can remove it if that issue has been fixed already.
- I've added world currencies to the stormattribute.install file. Probably overkill, I'll let you guys decide.

That's it for this patch. I welcome your comments, questions and especially complaints! :D

anodyne.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anodyne’s picture

Title: Cosmetic: Give admin to rename Storm in UI to something else more appropriate » Cosmetic: Give admin ability to rename Storm in UI to something else more appropriate

Status: Needs review » Needs work

The last submitted patch, storm-6.x-1.x-dev-stormrenamer.patch, failed testing.

juliangb’s picture

It would be helpful again if the attributes / currencies bit can be separate - these are separate features so each one is a separate conversation.

My initial comments about the subject of this issue - the ability to rename is that i'm ok with this, but functions like t() need to use placeholders etc., they must not use t('qqq '. variable_get(...) .' qqq'), as that doesn't translate well.

I'll have another look once the testbot likes the patch.

anodyne’s picture

You make a very good point about translation julian,

I've looked at using placeholders :
http://api.drupal.org/api/function/t
but that doesn't seem to be a good approach for user-defined strings.

The tt() function appears to be what I'm after.
Downside being, Storm would become dependent on Internationalization / i18n (specifically i18nstrings).

What do you think ?

anodyne’s picture

Status: Needs work » Needs review

CNR to check #4.

Status: Needs review » Needs work

The last submitted patch, storm-6.x-1.x-dev-stormrenamer-rev2.patch, failed testing.

tchurch’s picture

subscribing

ShannonK’s picture

subscribing.

qriz’s picture

Isn't
String Overrides

able to do this????

juliangb’s picture

Status: Needs work » Closed (won't fix)

Yes, String Overrides should be used for this.