I'm using storm for a helpdesk situation and found that staff had no idea what "Storm" meant, so I went through and added the ability to refer to Storm with a different name in the UI.
Notes:
- I have a feeling changing references from Storm to [admin provided alternative string] in the Drupal Permissions list is going to cause issues. So I may need to ditch that portion of my patch. :(
- There was a separate issue in stormticket/stormticket.views.inc where ticket was misspelled "ticet". This is included, but I can remove it if that issue has been fixed already.
- I've added world currencies to the stormattribute.install file. Probably overkill, I'll let you guys decide.
That's it for this patch. I welcome your comments, questions and especially complaints! :D
anodyne.
Comment | File | Size | Author |
---|---|---|---|
#4 | storm-6.x-1.x-dev-stormrenamer-rev2.patch | 41.88 KB | anodyne |
storm-6.x-1.x-dev-stormrenamer.patch | 49.61 KB | anodyne | |
Comments
Comment #1
anodyne CreditAttribution: anodyne commentedComment #3
juliangb CreditAttribution: juliangb commentedIt would be helpful again if the attributes / currencies bit can be separate - these are separate features so each one is a separate conversation.
My initial comments about the subject of this issue - the ability to rename is that i'm ok with this, but functions like t() need to use placeholders etc., they must not use t('qqq '. variable_get(...) .' qqq'), as that doesn't translate well.
I'll have another look once the testbot likes the patch.
Comment #4
anodyne CreditAttribution: anodyne commentedYou make a very good point about translation julian,
I've looked at using placeholders :
http://api.drupal.org/api/function/t
but that doesn't seem to be a good approach for user-defined strings.
The tt() function appears to be what I'm after.
Downside being, Storm would become dependent on Internationalization / i18n (specifically i18nstrings).
What do you think ?
Comment #5
anodyne CreditAttribution: anodyne commentedCNR to check #4.
Comment #7
tchurch CreditAttribution: tchurch commentedsubscribing
Comment #8
ShannonK CreditAttribution: ShannonK commentedsubscribing.
Comment #9
qriz CreditAttribution: qriz commentedIsn't
String Overrides
able to do this????
Comment #10
juliangb CreditAttribution: juliangb commentedYes, String Overrides should be used for this.