Hi,

this patch adds a 'view vote up/down count on comments' permission similar to the vud_node's one.

CommentFileSizeAuthor
#5 comments_count.patch1.51 KBdroplet
#1 vud_comment.module-view-perm-v2.diff2.4 KBtuffnatty
vud_comment.module-view-perm.diff2.12 KBtuffnatty

Comments

tuffnatty’s picture

tuffnatty commented
StatusFileSize
new vud_comment.module-view-perm-v2.diff2.4 KB

This one is better, the alert message actually works.

marvil07’s picture

marvil07 commented

thanks for the patch!

IMHO is better to see this after #807934: Let choose vud node view behaviour

marvil07’s picture

marvil07 commented
Status: Needs review » Postponed
marvil07’s picture

marvil07 commented
Title: vud_comment view permission » Add view permission to vud_comment and vud_term
Version: 6.x-2.x-dev » 6.x-3.x-dev
Status: Postponed » Needs work

INHO it's better to do this for both vud_comment and vud_term, so we could have thi feature in all our submodules, so I think this issue is the best place to do that.

droplet’s picture

droplet commented
StatusFileSize
new comments_count.patch1.51 KB

was thought to patch #939698: View only permission for vud_comment, when I back to issues list and see this. I think my patch is more right to here

anyone can point me out why we need permission check on hook_link at this situation, thanks.

maddy121’s picture

maddy121 commented

Thanks! #1 patch works perfectly for me.

droplet’s picture

droplet commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, comments_count.patch, failed testing.

marvil07’s picture

marvil07 commented
Version: 6.x-3.x-dev » 7.x-1.x-dev

No more features for 6.x-3.x now that it is the stable branch, moving to 7.x-1.x.

marvil07’s picture

marvil07 commented
Status: Needs work » Postponed

Postponed until basic port is ready.

marvil07’s picture

marvil07 commented
Issue summary: View changes
Status: Postponed » Active