Download & Extend

Add view permission to vud_comment and vud_term

Project:Vote Up/Down
Version:7.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:postponed

Issue Summary

Hi,

this patch adds a 'view vote up/down count on comments' permission similar to the vud_node's one.

AttachmentSizeStatusTest resultOperations
vud_comment.module-view-perm.diff2.12 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vud_comment.module-view-perm.diff. This may be a -p0 (old style) patch, which is no longer supported by the testbots.View details | Re-test

Comments

#1

This one is better, the alert message actually works.

AttachmentSizeStatusTest resultOperations
vud_comment.module-view-perm-v2.diff2.4 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vud_comment.module-view-perm-v2.diff. This may be a -p0 (old style) patch, which is no longer supported by the testbots.View details | Re-test

#2

thanks for the patch!

IMHO is better to see this after #807934: Let choose vud node view behaviour

#3

Status:needs review» postponed

#4

Title:vud_comment view permission» Add view permission to vud_comment and vud_term
Version:6.x-2.x-dev» 6.x-3.x-dev
Status:postponed» needs work

INHO it's better to do this for both vud_comment and vud_term, so we could have thi feature in all our submodules, so I think this issue is the best place to do that.

#5

was thought to patch #939698: View only permission for vud_comment, when I back to issues list and see this. I think my patch is more right to here

anyone can point me out why we need permission check on hook_link at this situation, thanks.

AttachmentSizeStatusTest resultOperations
comments_count.patch1.51 KBIdleFAILED: [[SimpleTest]]: [MySQL] Unable to apply patch comments_count.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots.View details | Re-test

#6

Thanks! #1 patch works perfectly for me.

#7

Status:needs work» needs review

#8

Status:needs review» needs work

The last submitted patch, comments_count.patch, failed testing.

#9

Version:6.x-3.x-dev» 7.x-1.x-dev

No more features for 6.x-3.x now that it is the stable branch, moving to 7.x-1.x.

#10

Status:needs work» postponed

Postponed until basic port is ready.

nobody click here