Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Hey! The ParserIcalDateTimeElement class includes files to work with repeating dates. However, under the new batch feeds model it is possible that the object will be created on one page and used on another, so these files and functions won't exist, causing a crash. This patch should fix the problem.
David
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | parser_ical.745370-2.patch | 1.71 KB | ekes |
| ParserIcalFeedsParser_batch.patch | 1.86 KB | David Goode |
Comments
Comment #1
ekes commentedHi, thanks for this. For some reason your patch fails to apply
But anyway, reading the patch, I understand adding include_once if date_repeat.inc may not have been included before in this batch (line 91 onwards). But it should still be included before line 45 (where date_ical_parse_rrule() is called) shouldn't it? As they are include_once it's fine if it's in there twice.
Comment #2
David Goode commentedHey, sorry yeah there were some other changes and I tried (unsuccessfully apparently) to edit the patch by hand :-) The line should be added around line 91, but it actually isn't necessary at line 45 because none of those API calls actually involve the include. It would be fine to leave it in though.
David
Comment #3
Anonymous (not verified) commentedare your recurring events working in general? I was having problems getting recurring events to work at all. The original event is added, but none of the recurring ones.
I tried the patch here with the same results.
I also tried the test School.ics calendar included with parser ical, and it didn't handle those properly either.
**Edit**
Ahh i had never enabled the options in the Date field to handle recurring events so it never worked.
With it enabled and this patch things seem to be working well.
Comment #4
ekes commentedRevised and ready to go - shall get there later today.
Comment #5
ekes commentedhttp://drupal.org/cvs?commit=365238