don't list default roles & introduce views_handler_filter_default()

That's right.

There is an entry for anonymous users in the users_roles table, so only the role for authenticated users needs a special handling.
The attached patch adds a custom handler for this. To enable reusing of existing code I created a function views_handler_filter_default(), which does the default filter handling. I left this function in views_query.inc directly under the original code, hopefully that's ok so?

Further I stripped the function views_handler_filter_usercurrent_custom, which isn't used any more.

oh sorry, there were some conflicts with the table alias prefix patch.

I've attached a new patch made with a clean views-head install. It includes some further tiny code improvements.

hm, yeah it would made sense to split it, however this patch wouldn't be as simple if the other one isn't in, because then I would have to copy these default filter handling code to the custom handler too...

so to simplify it I would like to reroll it and either
* keep it together or
* make two patches, where the second one depends on the other one, which introduces views_handler_filter_default()

ok, here is the first part of the patch, which introduces views_handler_filter_default(), so that custom filter implementations could reuse it.

attached is the patch for 5.x

and here is the one for 4.7

here is a patch for 4.7, that fixes the role: author by role filter for 4.7 for all possible operations and roles.

it also moves the views_handler_filter_role() function to the user.inc, the only places where it is used and it removes the unused function views_handler_filter_usercurrent_custom().

I also wanted to make a patch for 5.x for this changes, however there is problem: drupal 5.x doesn't include the anonymous role 1 in the user roles table anymore. it got deleted with system_update_171. so this makes things rather difficult, but I'll have a look at it tomorrow.

so, it's done. attached is a patch for 5.0 which also fixes the role: author by role filter for all possible operations and roles :)

as the patch for 4.7 it also moves the views_handler_filter_role() function to the user.inc, the only places where it is used and it removes the unused function views_handler_filter_usercurrent_custom().

here it is

and here is an updated patch for 4.7 - now it makes also use of the drupal constants DRUPAL_ANONYMOUS_RID and DRUPAL_AUTHENTICATED_RID for better readibility.

backport? this is in views 5.x and it is working fine for me.
If you are manually applying these patches apply both! (Read the whole issue.)

ah, indeed. sry robroy..

Puh, what a zombie! Let's kill this issue merlin ;)
You forgot to commit the patches from the comments #8 and #9.