I would be great if we could get the "pre-authenticated" role to show up in a logical order on admin/user/permissions. While this problem exists for all roles (like any "admin" role should be after an "editor" role), I'm not sure LoginToboggan should get into that, considering it doesn't know anything about those other roles.

So this patch simply adds new weights to the anonymous, authenticated, and pre-authorized roles to put them into order. It's done using #pre_render, so it shouldn't affect existing theming and should be compatible with most other approaches that modify this same form.

I will try and handle this in Drupal 7 through #228061: Usability UMN: Allow roles to be weighted, which would make this unnecessary in Drupal 7.

CommentFileSizeAuthor
logintoboggan_order_roles.patch1.63 KBquicksketch

Comments

hunmonk’s picture

hunmonk commented
Status: Needs review » Closed (won't fix)

this is a cool idea and a clean implementation. however, i think it's limited to do this way, and not really suited for this module. i'd much rather see it implemented in it's own module, and allowing the admin to order the display of all roles.