Getting white screen on "Join Group"

Thanks for the heads-up. It's been awhile since I've looked at the module, and some recent changes to OG caused the module to break. No worries, though - the fix is quite easy.

I'm currently having trouble with CVS, but the fix involves updating og_joinrole.module's hook_menu function as follows:

function og_joinrole_menu() {
  $items = array();
  
  // This menu item overrides the og menu item to add the access stuff
  $items['og/subscribe/%node'] = array(
    'type' => MENU_CALLBACK, 
    'file path' => drupal_get_path('module', 'og'),
    'file' => 'og.pages.inc',
    'page callback' => 'og_subscribe',
    'page arguments' => array(2), 
    'access callback' => 'user_access',
    'access arguments' => array('subscribe to organic groups'),
    'title' => 'Subscribe to group',
  );
  
  $items['admin/og/og_joinrole'] = array(
    'title' => 'OG joinrole',
    'description' => t('Set various options for the OG join role module.'),
    'page callback' => 'drupal_get_form',
    'page arguments' => array('og_joinrole_admin_settings'),
    'access callback' => 'user_access',
    'access arguments' => array('administer organic groups'),
    'type' => MENU_NORMAL_ITEM,
    'description' => 'OG joinrole options.',
  );
  
  return $items;
}

As soon as I get my CVS issue worked out, I'll commit the change.

-mike

Thanks it work for me!

This fix isn't working for me...

warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'og_subscribe' was given

I'm in the same boat as gorgo - there's nothing to fix and I have the same error message. It happens with a white screen both when attempting to join a group and also when attempting to invite a user.

Gorgo and trespass71 - please confirm you changed the code as outlined in comment #1 above and cleared all caches.

Thanks,
-mike

I'm sure I did. Just for you, though, I went back in and did it again. The error message is the same after I backtrack away from the plain white screen:
warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'og_subscribe' was given in /home/ ... /menu.inc on line 348.

EDIT: With inviting a friend, I get this warning instead:
warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'og_invite_form' was given in /home/ ... /form.inc on line 372.

I just tested the module and wasn't able to reproduce the errors you listed above.

I did, however, get my CVS stuff straightened out, so I went ahead and committed the new version of the og_joinrole.module file here.

I would recommend grabbing a copy from here: http://drupalcode.org/viewvc/drupal/contributions/modules/og_joinrole/ (or wait a few hours until a new dev version is automatically generated) and give it another try.

If it still doesn't work, contact me via my contact page with a URL where I can check things out on your site.

Thanks,
-mike

Hi Mike,
Sorry to say the error is still there for me...

"warning: call_user_func_array() [function.call-user-func-array]:...."

Are you using Organic Groups 6.x-1.x or 6.x-2.x?

OG Join Role requires 6.x-2.x...

-mike

yep
using 6.x-2.1

-Guy

Ah - I think I just found and fixed it. Turns out it was a pretty easy fix. I just committed it, so it'll show up in the -dev version as soon as the Drupal.org packaging script gets to it (within the next 12 hours). If you want it sooner, you'll have to grab it from the CVS.

Please confirm the fix, then close this issue.

Thanks,
-mike

I might be crazy but it looks like the Drupal.org packaging script got to the 5.x version and not the 6.x version.

I am still getting the error with the latest 6.x-1.x-dev.

P.S. When I grab the latest from CVS the problem definitely resolves (yay!)
http://drupalcode.org/viewvc/drupal/contributions/modules/og_joinrole/og...

Yes, clearly my lack of CVS skills are on full display.

I just made a change to the 6.x release - I'm hoping that will fix the problem. In the meantime, the version from CVS is the latest.

-mike

Yeah it's working for me now too!

I was wondering if there is a way to add an option so that instead of GRANTING permission to join groups, you disable roles from joining groups.
Basically all authenticated users can join any group and I have a role for group admins. I want to block group admins from joining other groups.
Because Group Admins are also Authenticated Users, if I allow authenticated users to join groups, even if the box is unchecked for group admins, they can still join...

any advice?

Thank you!
-Guy

Guy,

I'm not sure that what you're describing is possible - even if it is, it is probably not the best way to go.

I would suggest adding a new role that allows users to join groups and giving all your "authorized users" this new role by default (I believe there are a number of modules that allow you to assign roles automatically). Then you can not give this role to your Group Admin users.

At least that's what I would do...

-mike

Thanks for the advice, Mike.

I know it's dumb but for some reason I don't like creating "general" roles. I can't even explain why, I just have a gut feeling that if I do that I'm gonna find out! :)

To be honest (I think I mentioned that before) the only reason why I wanted to prevent group managers from joining other groups is because I'm also using U Create module and I didn't want group admins to have the ability to add users to groups they don't manage.

It's been a while since I posted this topic and I was very new to drupal. I gained some experience now and decided to take a look at the code for the ucreate module again and to my surprise, it took about 5 minutes to find the piece of code I needed to modify to fix it, so now I don't really need to prevent group managers from joining other groups at all!

I really appreciate your help though. So glad I got into Drupal! LOL
All the best,
Guy.

No worries. Glad it worked out!

-mike

Closing.

-mike