when I create an order - all looks good.

in checkout it looks like this (once I've selected a VAT free shipping item):
Products Subtotal:
Brev (A - Prioritaire): 5,50 Kr.
Handling: 10,00 Kr.
Subtotal excluding Moms: 29,50 Kr.
Moms: 6,00 Kr.
------
Total for this Order: 35,50 Kr.

On the order_review page it's wrong:
Moms (ie. DK name for VAT) is now 4,00 kr. - total is correct though.

Then when I view the orders - the total is correct.

When I view this new order - it now looks like this:
Brev (A - Prioritaire): 5,50 Kr.
Handling: 8,00 Kr.
Subtotal excluding Moms: 29,50 Kr.
Moms: 4,00 Kr.
Total: 29,50 Kr.

Notice that now handling is shown without VAT (8 kr. instead of 10).

And when I view the order list again - 29,50 is the new order total shown.

p.s. I've got the latest uc_vat dev version installed (11/3 2010) and the "Handling" comes from uc_fee module.

Comments

klavs’s picture

klavs commented

I just noticed that the order-review page calculates correct VAT amount the SECOND time you enter it.

1) go to checkout and confirm VAT amount is correct.
2) press order_review - VAT from fees should be missing
3) press back button
4) wait until ajax finishes and press order-review button again
5) notice that now VAT from fees is included in the VAT total

This seems as if it's 2 issues:
1) uc_fee compatability issue
2) order_view - forgets to add VAT to order total.

klavs’s picture

klavs commented

I've confirmed issue 1: uc_fee compatabity issue.

I've installed a site: http://cleantest.virkpaanettet.dk - where you can try an order the 1 item there is, and see the problem.

I am working on adding modules/configuration to the cleantest site - until it reproduces my second (and worst) problem.

klavs’s picture

klavs commented

I've confirmed the second issue.

When you have a CA on taxes - saying that taxes are only to be applied to customers within EU - then the problem appears (on a clean ubercart-6.x-2.2+latest uc_vat).

IMHO NO CA's should be checked on an "order view" - since this has already happened - the price should just be as it were, when the order was entered.

It's really bad that ubercart updates the order - when you simply view it :(

I realize uc_vat can't do anything about that- but I guess the fix may be loading the $order object and ensure the relevant $order information in $context and $options are set?

klavs’s picture

klavs commented

I found the CA cause. my new "if delivery country is inside EU" - for some reason doesn't work in admin view.
I replaced that with a manually selected list of countries in EU (check on delivery country) - and that works.

I'm guessing it may be because I defined countries, that aren't imported into ubercart (pure guess though) - but I don't know.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I just committed a change to HEAD that saves the correct set of taxes when an order is first saved, and should ensure they are always reused when loading the order again.

I've tested locally with uc_fee and can't reproduce the same problem; there are a few similar threads in uc_fee's issue queue so I suspect the problem may lie there, or maybe it could be a module or line item weighting issue. There is also a bug in Ubercart core if you are using attributes to apply taxes or fees: #600892: Attribute Value Based Tax Rules Disappear Between Checkout and Review

klavs’s picture

klavs commented

Great. I'll test it out once I get a chance.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Closed (won't fix)

This is probably a module weighting issue with uc_fee, as something similar occurs with uc_pma. Closing for now.

arski’s picture

arski commented

patch in http://drupal.org/node/656236#comment-2800336 seems to be fixing this.. review if you can