Download & Extend

uc_donate module contains D5 code - checkout pane fails to work

Project:Ubercart Donation Products
Version:6.x-2.0-beta3
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:reviewed & tested by the community

Issue Summary

The pane added to the ubercart checkout page by uc_donate doesn't actually update the order correctly with the additional amount. This means that when the user clicks through to the next payment page, the amount is not added to their order total. In addition that function, uc_donate_cart_checkout_form_validate(), uses Drupal 5 FAPI code, which is partly the cause.

The attached patch fixes this.

Cheers,
Stella

AttachmentSize
uc_donate_checkout_pane.patch2.14 KB

Comments

#1

Hi Stella,

After applying the patch, the order total still does not include the donation amount. Is there something I'm missing? A database configuration?

Chris

Update: I should clarify that the order does have the correct amount in the "Review order" step, but on the "checkout" step the payment pane shows:

  • Subtotal: $X
  • Added Donations: $Y
  • Order total: $X (should be $X+$Y)

#2

My orders look fine up to cart/checkout/review, and with the 'Check' payment method the order is created with the correct total.

Stella, at what point do you get the wrong total?

#3

There are two ways to add a donation to your order - one is by using the donation product node, but I was using the feature where you can add a donation amount on the cart or checkout page itself. Maybe that's the difference?

#4

Status:needs review» reviewed & tested by the community

Works for me, thanks. See #1367486