Closed (fixed)
Project:
CCK Blocks
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Reporter:
Created:
18 Mar 2010 at 13:58 UTC
Updated:
2 Apr 2010 at 10:20 UTC
Jump to comment: Most recent, Most recent file
The module could generate a lot of blocks but have no uninstall function.
Because D6 core have bug described in #735900: Deleting module's blocks when module is uninstalled the uninstall is required.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | cck_blocks-uninstall-followup.patch | 1.05 KB | Anonymous (not verified) |
| cck_blocks-uninstall.patch | 1023 bytes | andypost |
Comments
Comment #1
Anonymous (not verified) commentedWe should not only remove the variables but also the blocks generated by cck_blocks. Please do a review for my patch. It contains your changes as well.
Comment #2
andypostNo, it's a task for http://api.drupal.org/api/function/drupal_uninstall_module/6 which is broken now in D6 and should be fixed as D7
Clear modules' block is a task or core, none of contrib modules are do it now, also this already commited to D7 - clean {blocks} and {blocks_roles}
As I point at http://drupal.org/node/735900#comment-2705428
Gabor already confirm this bug and it would be great if you help to test this patch
So I recommend to commit my patch or add cleaning of {blocks_roles} too
Comment #3
Anonymous (not verified) commentedI decided to wait for the core patch to be committed and added your patch.
Comment #4
andypostCould you help with #735900: Deleting module's blocks when module is uninstalled
An opinion or reviewing... I think all modules with blocks need this