Posted by beginner on July 20, 2006 at 10:20am
| Project: | Remember Filter |
| Version: | 5.x-1.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Issue Summary
This nice little module does not work for comments, only for nodes.
Also, the current 4.7 release has a bug even for nodes that has been fixed in cvs. Maybe you can update 4.7, or make a note on the project home page to download the cvs release for a 4.7 site.
Comments
#1
I've updated the tag on the CVS file, so it should now (or soon, at least) work for 4.7. Thanks for mentioning that.
With regard to comments, the module works by using the nodeapi hooks, which comments don't use, so this is a known problem. If you (or anyone) would be willing to write a patch that will add this feature, I'll happily commit it.
#2
I have added some code that make the module work also for comments. I took the opportunity to convert some tabs to spaces while I was at it.
On my test site it seems to be working well but I'm not to happy with my implementation, it feels like a hack. Anyone has a better way of doing this?
#3
A small update to my patch. The help function was missing a ($section).
#4
It looks good to me. If you can find one more person to test it and confirm that it works, I'll apply it.
Otherwise, I'll test it myself the next time I'm working on Drupal, and apply it then.
Oh, and what version are you using to test it?
Thanks!
Steve Simms
#5
I'm running it on Drupal 4.7.5, soon to be 4.7.6. It's been up and running now for a couple of month and still seems to work well.
#6
Updated the patch for Drupal 5.