Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
image system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
19 Mar 2010 at 10:32 UTC
Updated:
1 Jan 2015 at 13:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
YurkinPark commentedit just old version of GD extension of PHP without rotateimage function
Comment #2
YurkinPark commentedComment #4
YurkinPark commentedwith rules of testing
Comment #5
YurkinPark commentedComment #6
eojthebraveSee also #758628: Improve GD library hook_requirements() for color and image modules
That issue provides a patch that performs a requirements check for imagerotate and imagefilter support and displays a warning if they are not available.
However, we might want to also consider implementing something like #4 here where we hide the desaturate and rotate effects if they are not available. I'm not sure what kind of consequences this would have for contrib modules implementing hook_image_default_styles and hook_image_styles_alter which allow modules to assign effects to an image style. What happens if the effect doesn't actually exist?
Someone should probably test this out.
Comment #7
catchPlease fix the whitespace issues in the patch.
if ($foo)instead ofif($foo).Comment #8
mrded commentedChanged to Drupal coding standards.
Comment #10
mrded commentedSorry, it was my syntax mistake. Check out new patch.
Comment #11
claudiu.cristeaI think this needs to be fixed in 8.x first and then backport to D7.
Comment #12
mrded commentedIn Drupa 8 it has been fixed already:
Comment #13
sivaji_ganesh_jojodae commentedThis has been fixed in recent drupal 7.x branch.