We want to use the video_filter module, but some of the default codecs aren't appropriate for the site (for example, 'myspace' and 'collegehumour' don't set well with the brand).

Rather than hack the unwanted codecs out of the module, I'd like to allow other modules to alter or unset the defined codecs, for example, via a hook_codec_alter.

CommentFileSizeAuthor
#7 video_filter_codec_alter_747074_7.patch1.55 KBcrea
#1 747074-add_hook_codec_alter.patch1.39 KBmanarth

Comments

manarth’s picture

manarth commented
StatusFileSize
new 747074-add_hook_codec_alter.patch1.39 KB

Patch attached...

replaces all 'module_invoke_all' calls with a call to a helper function.
Helper function calls module_invoke_all, then passes the results (by reference) through hook_codec_alter.

manarth’s picture

manarth commented
Status: Active » Needs review
anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented

Nice idea.

What about settings for this instead? So users with no php skills can enable/disable codecs?

blackdog’s picture

blackdog commented

I like both ideas.

Should the settings be for each format, or a global setting?

anon’s picture

anon
Primary language Swedish
Location Gothenburg
commented

For each format I think, but not sure on how to deal with this tho.

blackdog’s picture

blackdog commented
Version: 6.x-2.7 » 6.x-3.x-dev
Assigned: Unassigned » blackdog
Status: Needs review » Needs work

This needs to go into the 3.x branch. I'll take another stab at it.

crea’s picture

crea commented
Status: Needs work » Needs review
StatusFileSize
new video_filter_codec_alter_747074_7.patch1.55 KB
blackdog’s picture

blackdog commented
Status: Needs review » Fixed

Good stuff crea!
I've committed the patch with one change, I named the alter video_filter_codec_info. In both 6.x-3.x and 7.x-3.x. Thanks!

If someone need an UI for this, let's open a new issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.