Posted by hannibalector on July 20, 2006 at 10:14pm
| Project: | Voting |
| Version: | master |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Hi,
i set voting to show up on all images, but not on blog and all other nodes.
it was shown up in images AND blog
and when i'm creating new content, it isn't shown up anymore! you can only vote on old content.
wut to do? it just won't show up, doesn't matter what settings i'm using.
look at screenie.
| Attachment | Size |
|---|---|
| votiss.png | 107.15 KB |
Comments
#1
I'm seeing this too - don't know what happened.
#2
same here - was working ok, then stopped after 1-2 days - ALL functionality disappeared- works only on older posts, reloading modules does not help... on 4.7
#3
I just tried this on a fresh install - the voting stars up showed up on the first item created, but once I edited that item they disappeared and wouldn't show up on any subsequent items.
#4
Just go's away..? can see Voting on older nodes.. not new ones... even though activated for these content types ..(Story, Page, etc.)
#5
This is happening to me as well. I just installed - seemed to work, and then it disappears. Doesn't (and never did) appear in the teaser either.
#6
Experienced same issue. If I set the voting to Always appear, it seems to retroactively set this for all existing nodes, but for new nodes i create after that, the voting does not appear (until I go back to voting configurations page, and do an update).
Also, when trying to save configuration with "Show voting in teaser" set to YES, it keeps reverting the setting to no, even when the message says the configuration is saved.
This module looks great, I wish this few minor problems can be ironed out soon.
Thanks,
#7
I'm waiting to deploy the "voting" module to my production upgrade site from 4.6.x to 4.7.3 as well. On my test 4.7.3 upgrade site, I'm seeing erratic behavior. Please update this as soon as your schedule permits you to! Thanks!
#8
If you run
<code>UPDATE `node_voting` SET `voting` = 1 WHERE 1it will turn voting back on for all nodes. I haven't tested whether it stays on for new nodes yet.
#9
oops, didn't mean to change the title
#10
Hickory,
Voting is not working anywhere in the site for me. I am using drupal 4.7.3
Please help
#11
Here's a patch that should help in most cases. It forces the voting module to respect the "always" setting in content types.
The problem is that when you add a new node, the voting module is always setting "voting" to 0 in the node_voting table. This patch should get things working for you again, but ultimately this more fundamental issue should be fixed.
#12
Drawk,
I am afraid I am not familiar with the cvs program so dont really know how to apply the patch. Could you please tell me what changes i need to do in the code and I shall do it manually.
Manuj
#13
You don't need to know CVS. Just download the patch file above. It is plaintext, so if you really want to, you can figure out what to change just by reading it.
Using the patch is much easier than doing it manually though. Check this node: http://drupal.org/node/34422 for instructions.
#14
did anyone get this patch to work?
#15
I just tried your patch 2 mintues ago and it does enable the voting
however the voting is appearing on the starting of the article rather than in the end. To get an idea of what I am talking about, go to the following url http://www.delhilive.com/rajpath_0
Manuj
#16
Yes, I ended up having a similar problem. It is something seperate -- I believe it was addressed in one of the previous bug reports. I don't recall off hand exactly what needed to be done to re-enable the top or bottom option on the settings page.
Anyways, I have made a couple of changes and will be uploading an updated version of the patch in a day or so.
#17
Am i doing it right. I open the voting module then i find where the patch matches the code, i then delete that part of the code and paste the patch instead. However i end up with error messages.
#18
blackrain...this is how the code should look like from line 395 to line 405 in the voting.module after the changes.
case 'load':$result = db_query("SELECT voting FROM {node_voting} WHERE nid = %d", $node->nid);
$node->voting = variable_get("voting_nodeapi_{$node->type}", 'always');
if ($node->voting == 'always') {
$node->voting = 1;
}
else
if ($voting = db_fetch_object($result)) {
$node->voting = $voting->voting;
}
else {
Manuj
#19
thank you
#20
Change the line:
$node->voting = variable_get("voting_nodeapi_{$node->type}", 'always');
to:
$node->voting = variable_get("voting_nodeapi_{$node->type}", 'never');
Otherwise, you sometimes end up with the voting controls showing up on pages that they shouldn't.
(this was a mistake in my original patch)
#21
changes updated in my site..
thanks drawk
#22
np.
I've got a small list of changes I've found necessary to the module here.
Does anyone know if benshell is still actively involved with this module? It has been ten weeks since his last commit. Webchick is listed as a maintainer as well, but hasn't been active with it for over a year.
#23
Obviously I'm not very actively involved, but I'm still listening. If someone wants to take over as maintainer that'd be fine with me. I've love to be more involved, but the reality of the matter is that I don't have much time at all.
#24
Cool, good to know that you are out there listening :)
I'd be willing to take over maintainership, except that I hate mucking around with Flash. The Drupal/PHP aspects would be fine with me, but I really don't dig the idea of having to wade into the .fla, should it come up. I do think a 5.0 JQuery version would be cool, though and would be happy to contribute towards that ...
#25
drawk,
As mentioned in my previous comment no 15,voting is appearing in the starting of the article rather than in the end. Can you please look into the issue.
Manuj
#26
Manuj --
In function voting_settings(), change the second instance of
$form['general']['voting_location'] = array(
to
$form['general']['voting_show_in_teaser'] = array(
Then go back into your admin >> settings >> voting page, and resave your settings. That should fix it for you. More detailed information at http://www.whatwoulddrupaldo.org/changes-to-the-voting-module
Benshell just added me as a maintainer for the project, so I'll be able to commit some of these fixes to CVS.
#27
fixed.
thanks drawk.
#28
np.
This has been fixed in the CVS version: http://drupal.org/node/25640/release
#29
marked as closed
#30
re-opening. It was Manuj's problem that has been fixed in CVS, not the original poster's problem.
#31
ahw man why is all this info hidden in here, I spent hours trying to fix things myself (and I don't know php).
it would be nice if someone edited the project page with a notion to download the HEAD thingy isntead of the 4.7 one.
#32
Updating to version HEAD fixed this for me...
#33