Posted by m_rookie on March 19, 2010 at 10:30pm
3 followers
| Project: | Webform |
| Version: | 7.x-3.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
We were looking into the newest version of webform. We received a quite a few errors using the date, grid and select field types,
undefined functions expand_radios .... etc...
changed those functions to the new form_process_radios (date, time )
We didn't know if you were working on it, but here you go!
| Attachment | Size |
|---|---|
| d7-changes.patch | 4 KB |
Comments
#1
Thanks! Yeah the Drupal 7 version is extremely untested at this point (maybe it should've been called alpha), but I wanted to maintain the two branches in sync so we had to start with something. Also important to note is that I'm not yet writing upgrades for the Drupal 7 version. Meaning that when the beta3 version comes out, you'll need to uninstall and reinstall Webform in Drupal 7. While this may seem harsh, right now you can't upgrade Drupal 7 from Drupal 6 at all, making my testing of upgrade paths next to impossible at this point. Adding inner-Drupal 7 updates requires knowing how the upgrade from Drupal 6 works, so updates don't get applied twice.
So basically, I very much appreciate the patch, but please don't expect to be able to use the Drupal 7 version for ANY practical purpose at this point, don't even install it on any site you eventually plan to put into production, since upgrading it is not supported.
#2
I've committed your changes with a small revision. I excluded the changes to time.inc, since they were non-functional. And I changed "grid_element" to just "element" in hook_theme() rather than the other way around.
#3
#4
Oh, I get why you did the change to time.inc. I'll be wrapping in that change into #712352: Convert time component to use seconds in the day (timestamps), which I'm working on presently.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.