Hallo,
thanks for that fine module.

By using it, it seems, that it does not catch all nodes:
- First were about 17.500
- After deleting them, there remained 46 Nodes
- After deleting them, there remained 3 Nodes.
- After deleting them, there remained 1 Node.
- It was not possible deleting it with bulk delete. I deleted it manually :-)

I can live with that behaviour and report this just for your interest...
Thanks,
Ralf

Comments

kars-t’s picture

kars-t commented
Status: Active » Needs work

This was because of the main loop.

  while ($row = db_fetch_object($result)) {
      $count++;
      if ($count % 20 === 1) {
        $operations[] = array('bulkdelete_node_delete', array($nids, $node_deletes));
        $nids = array();
      }
      else {
        $nids[] = $row->nid;
      }
    }

The node ID is ignored if the modulo is 20. 

 while ($row = db_fetch_object($result)) {
      $nids[] = $row->nid;
      ++$count;
      if ($count % 20 === 1) {
        $operations[] = array('bulkdelete_node_delete', array($nids, $node_deletes));
        $nids = array();
      }
    }

Now any node ID is always added. So it will be pushed into the batch after this loop.

I already fixed this in CVS but currently can't access the cvs.

kars-t’s picture

kars-t commented
Status: Needs work » Fixed

Should be fixes in Version 1.1.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.