Bartik needs a print stylesheet

this patch is a start ... not sure if I'm going too far with this hunk:

#navigation,
#toolbar,
.tabs,
.add-or-remove-shortcuts {
  display: none;
}

I don't *think* these admin elements should be printed, but maybe I shouldn't assume? Thoughts?

Also, this hunk removes the comment form (etc...) should we? Shouldn't we?

#comments .title,
#comments form,
.comment_forbidden {
  display: none;
}

There are likely some other changes to make, but after taking a look at garland's print.css it looks like print stylesheets don't do too much currently.

Did you have any issues getting Drupal to recognize the new file and load it up, being stubborn for me... grrr, using D7 alpha 3.

Edit, loading now, I was clearing the theme registry using Admin Menu but that wasn't doing it, clearing the cache on the performance settings page did it.

Should we print sidebars, footer, triptych or just the content? I'm not sure what the best practise is here, I know when I print a page I usually only want the main content.

There's a quite cool bit of CSS in Zen, any thoughts about including this?

/* CSS2 selector to add visible href after links */
#content a:link:after,
#content a:visited:after {
  content: " (" attr(href) ") ";
  font-size: 0.8em;
  font-weight: normal;
}

I think its good to print comments, that may be part of why someone wants to a print out a page, thinking of a forum post + comments. I've just been doing this on several sites myself so I was thinking of it (I was collecting reviews of products).

so just to be clear ....

1) its ok that I've hidden the comment form from the printable version but we agree that the comments themselves should remian because we shouldn't assume that people dont want them printed.

2) I really like the suggestion Jeff Burnz made in #3 about printing hrefs next to links ... I'll add that

3) Any opinions about "Should we print sidebars, footer, triptych or just the content?" I think we should err on the side of leaving things in unless its really obvious (like the comment form). Anyone else?

Other thoughts?

I'm pretty happy with that bleen18, I tend to agree about erring on the side of leaving things in and not making to many assumptions, apart form the obvious things like the comment form (but not all forms, in case user actually does want to print a web-form or something). All good.

bleen said

"Should we print sidebars, footer, triptych or just the content?"

I think we should print sidebars, footer, triptych. We can't make assumptions that the most important content is $content — many times people setup Drupal sites to put the best stuff in blocks.

Yes?

hmmm ... I'm rethinking the nifty href trick that zen uses. Take a look at this screenshot. Thoughts?

I agree ... I think it looks messy to have them print at all. If everyone else agrees and there are no other suggestions, then I suggest we commit the patch from #1 as a good starting point and make changes if/when needed.

Quartz — what did we 'outvote' you on? I'm confused. I thought we were agreeing more should get printed than less.

I've committed this very first round. At least now the print style sheet will exist (a tricky thing to add in CVS) and more people can work on the code in the stylesheet.

Let's keep working on this.

I think we should call this "fixed" for now and if probs arise we can open a new issue. The spirit of this issue was to get a good, working print.css going and in Bartik and I think we achieved that. There will always be improvements to make.

I agree. Sorry I dropped off the map for a couple of days. Time got away from me at Drupalcon then I headed back east and just now got settled.

Let's closet his one out but I'll happily jump in on some other issues.

Wait. How did this get "fixed"? There was awesome work being done on the print stylesheet during the sprint, and I want that work in a patch so I can commit it! I do not consider the current stylesheet to be the final one.

rontec76 go for it! Remember you can always ask for help in IRC #drupal-contribute with rolling a patch or figuring out what to do next.

I think rontec76 was taking the conversation he and I had at Drupalcon as "no more work to be done..."

My argument was that we should not be hiding the blocks in the sidebar and only hiding things that are blatantly online-only (like the comment form or the search box) because we shouldn't be making assumptions.

While I stand by this argument, there are plenty of improvements that could still be made to the print.css

Its critical that we have a usable print.css ... which we do. I know that Jen wants it to be better than "usable" though, so priority = normal, but status is still "needs work"

Hi folks,

Sorry I dropped off the map after drupalcon. Fortunately I've been busy with work. :)

I'm happy to work on this more but I did decide to stop because of the convo with bleen18. On one hand I agree with Jen because I'd love all visuals of this theme to be amazing for the D7 release. On the other hand there are so many considerations for this that we could tweak it too much.

So, I ask for feedback here and I'm happy to do more work and contribute a patch. I still have the code that I did at drupalcon and can work off that or start new.

Just lemme know.

Ronnie! Welcome back. I would love to see what you have. Make a patch with where you are at, or drop it into http://drupalbin.com so we can see it. What we talked about still stands, and I think the work you were doing was great! I know this could be bikeshedded to death — but we don't have to go there. Let's just get what you had going going again.

Sounds good. I'll try to get that up by this evening! (I'm on EST).

Hi Jen,

I've attached my modifications of print.css. (sorry again I took so long).

Based on my conversations with you I have:

- hidden both sidebars for printing
- given the content column 100% width
- explicitly set the width of triptych-wrapper for printing. For some reason on my machine the triptych regions were all out of whack without it.
- set width of the triptych boxes to 250px for printing. again, for me at 280px they end up wrapping and making for very fugly printing.

Let me know what you think and I'm happy to make more adjustments.

Thanks!

@rontec76 thanks for posting this css... this should push the conversation forward :)

I don't think we should be hiding sidebars and/or blocks. There is no reason reason to believe that sites will not be putting important information in those sidebars that should still be printed. As an example, take a site that give restaurant reviews. The main content area might be the review itself, while the rail might contain the address and a small streetmap and its zagats rating.

I think its much more practical to say to a themer "if you want to hide that sidebar when printing you need to create your own print.css" than it is to say "We assumed that you wouldn't want that to print... if that was wrong, you should add your own print.css"

That isn't to say that we shouldn't hide anything (ex. the comment form need not be printed) but it should only be those things that dont translate to paper.

Other thoughts?

Hi @bleen18....

No problem and I'm happy to help. Basically what I submitted was what Jen and I agreed on at drupalcon before you and I had our little chat.

If I were in charge I'd leave the sidebars on the home page and any section front type page then hide nearly everything extra on the full node page. Your argument of accurately representing the page makes sense in the first two contexts but on a single full page node in most cases the thing a person is after is that one piece of content. Personally the few times I ever print content from a website it pains me to waste extra ink and paper for the crap that people stick in their sidebars, footers, etc.

All that said I'd like a group consensus before doing any more tweaking.

Anyone...thoughts, comments?

tagging

Jen ... any thoughts on #28/#29?

You both make very good points. I think I'm only leaning 51/49 in one direction, so its not a strong preference.

Bleen makes a good point that restaurants and some sites will have content in the sidebars rather then "extras" in the sidebars. However, aren't those sites going to also want branded themes?

I'm leaning very slightly to "hide both sidebars for printing and give the content column 100% width". [edit: this is what Zen 6.x does, btw, and I haven't heard any complaints.]

I'm with JonAlbin on this. Heck, if Zen is used on some 30,000 sites and he hasn't heard any complaints, than I think we can be safe hiding the sidebars here.

What do I think? I think it's impossible to know what's best when we have no idea what the content on the site using Bartik actually is going to be. Mostly, Garland gets used for Drupal developer websites, book screenshots, presentations, and super-fast 1-off sites.

I like rontec76's patch. Sounds like some of us agree, barely tipping in the direction of doing what he did in the patch, incluing not printing sidebars. It does save ink, and provide clean pages. Sounds like other (including a previous version of myself) are pro-sidebar-printing. Meh. It's so hard to know. I'm going to lean the way Zen is, and use rontec's patch as is.

Committed.

Jen,

I think that is a fine decision. The reality here i that there is no way to please everyone. That's the beauty of open source. If someone doesn't like the way it's set up they can tweak it.

Cheers. :)