Thanks for this module, it really helped with a project I was working on. I noticed that the module includes a file /contributions/modules/views_export_xls/libs/php-excel.class.php which (in the comments) claims to be under the MIT license @license http://www.opensource.org/licenses/mit-license.php.
I was under the impression that all code in cvs had to be covered by GNU General Public License, version 2 or later. See http://drupal.org/licensing/faq for details.
Perhaps this file should be removed from cvs and replaced with instructions on how to obtain this third party library? Just posing the question. I am not sure if this is the correct approach or not.
Comments
Comment #1
MGN commentedMoving this to the webmasters issue queue for clarification, as per http://drupal.org/licensing/faq.
Comment #2
creaoy commentedHmmm. I haven't give a thought about this.
I think i can modify this file a bit and use it under GPL.
I'm glad this module is useful.
Comment #3
Crell commentedMIT-licensed code can be relicensed GPL, so it's legal to include but the doc header for it should be changed to say something like "Based on blah blah". See here: http://www.softwarefreedom.org/resources/2007/gpl-non-gpl-collaboration....
Especially section 2.1.
That said, in most cases per Drupal.org policy (not copyright law) we ask that you do not include 3rd party code such as this unless it is difficult to obtain or install otherwise, or non-trivial changes are necessary to make it work. The definition of "difficult" and "non-trivial" is something that is decided by the webmasters team on a case by case basis.
Comment #4
damienmckennaMoving this back to the project's issue queue as a clear direction was provided by Crell in #3 above.