Download & Extend

[PATCH] usage of off-left damages RTL support (needs to be off-top)

Project:Acquia Marina
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:RTL

Issue Summary

off-left method (e.g. left: -999em) is bad for RTL, cuz when on RTL mode it widens the page on all browsers (forming a horizontal scroll bar), and puts the to-be-hidden element on a far, visible position.
I suggest simply moving to off-top - I'm not aware of any disadvantages of off-top.

Attached is a page.

More details in my blog post http://www.held.org.il/blog/?p=260

AttachmentSize
acquia_marina_change_off_left_to_off_top.patch869 bytes

Comments

#1

Status:active» closed (fixed)

Thanks for the tip, looks like we're not using this technique anymore in 3.x