Closed (duplicate)
Project:
RSS Permissions
Version:
6.x-1.1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
22 Mar 2010 at 01:21 UTC
Updated:
24 May 2013 at 04:11 UTC
Jump to comment: Most recent file
Comments
Comment #1
emilorol commentedHi,
I am having a similar issue. I installed the module and I didn't give anyone permissions to access the RSS feeds, but the RSS feeds are still available to anyone.
Any ideas on what am I missing?
Comment #2
phpdiva commented@kaakuu, Individual RSS privacy settings are outside of this module's functionality. You can only turn off RSS for everyone, not on per-user basis.
@emilacosta, your issue is completely different. Can you give me more details? URL to see? Other people have used this module with no issues, so it does work. You must be missing some step.
Comment #3
kaakuu commentedI see. But there were so many ways to do this in the other thread. Not saying that a module is not of utility. Thanks but I will like to keep it as a feature request. If anyone can solve this problem for the end-user Drupal users like ordinary registered members to a site.
Comment #4
emilorol commented@phpdiva,
Thank you for replying. I send you a message with site details using this site contact form.
In a nutshell, Drupal 6 (latest), Sky theme, Views and 2 vocabularies, nothing fancy or any hacks.
I installed the module and I didn't give permission to any user role to access the RSS to have RSS disable on the site.
Current status: any user can access the RSS in any taxonomy page
Thank you
Comment #5
phpdiva commented@emilacosta,
I think your issue is that you are using Views to display Taxonomy term page - which overrides the core functionality.
I think if you delete the "feed" pages in the taxonomy term view, it will disappear. I would export and back up the view before trying.
@kaakuu,
This is pretty much "by design". If you have a link to a specific comment that talks about how to accomplish this, I will be happy to look at it.
Comment #6
emilorol commented@phpdiva,
The term page is been display as a regular term page, the view on it is a block and not the whole page.
Comment #7
emilorol commented@phpdiva,
I saw the term view, I am not using that view. I just disable it and now the term pages still shows the RSS, but if you click on them you get an error in safari (win)
Also IE 8 get an error like this:
Firefox is the only one that shows me the proper error:
So far I can say that the taxonomy feeds are block now, but the regex to replace the:
is not working for me.
Thank you for pointing the unnecessary view that make it work and also thank you for this module.
Comment #8
emilorol commented@phpdiva,
I was playing with the module code and I found two things:
1. When the code check to see if the url is a taxonomy url:
There is a call to "user_access('access content')". Correct me if I am wrong, but even if you don't have access to 'access taxonomy RSS feeds' the return will be true or 1 if the user has access to 'access content' and this will affect the last function where it say:
I set a watchdog after that code using an "else" and it logged my point every time.
Comment #9
emilorol commented@phpdiva,
Any news or updates?
Comment #10
phpdiva commented@emilacosta, I want to narrow down your issue.
Can you try and disable your theme, and go back to one of standard Drupal themes? Does the RSS icon still show up then?
Regarding your comment #8, everything in the code is correct. The "&&" in the condition stands for "AND", which means that both conditions have to be true to return true.
"I set a watchdog after that code using an "else" and it logged my point every time." Does it still log "else" if you visit the page as a logged out user?
Comment #11
emilorol commentedHi phpdiva,
I am sorry it took me so long to post back.
I change the site theme back to the default theme and still does not remove the RSS feed code (I flushed all my caches too).
I will setup the watchdogs and I will post back my findings.
Once again thank you.
Comment #12
t.a. barnhart commentedi'm sorry, i have no idea how to use the module. you say i can turn off RSS functionality completely - where? how? i've spent nearly half-an-hour clicking every damn place i can think of, not to mention mucking about with permissions. could you please give some directions on use?
Comment #13
phpdiva commented@t.a. barnhart,
Everything is done through the permissions screen (admin/user/permissions). Just make sure no roles have permissions to view RSS content ("access site RSS feed", "access taxonomy RSS feeds", etc.). Just keep in mind that you won't see any difference as long as you are logged in as the admin. To test, you will need to log out or log in as a regular user. Hope this helps!
Also, not everyone is aware of this, but there is a help page where most modules will tell you how to use them: admin/help.
Comment #14
Daniel Norton commentedPerhaps this patch will help. It provides a page that disables RSS access globally. I wanted it because I didn't want the RSS feeds showing up when viewing the site as an admin.
I took the comment on the project description page at its word: "This also allows you to disable all RSS feeds altogether." This statement is false for admins. This patch makes it true.
The patch attached here is replaced by another, below.
Comment #15
Daniel Norton commentedThe attached patch replaces the one in comment #14.
Comment #16
jvieille commentedI am very interested by this mandatory improvement unless this module does not deliver what it pretends to offer.
However, the patch does not apply to the stable nor the dev release.
Update:
I applied the patch manually against the last dev. This works great: I can now prevent RSS publishing when working on content that I do not want to be spread in real time.
This was a really missing feature.
Thanks for the fix, I hope it will be committed in the next dev.
Comment #17
phpdiva commentedThanks, @Daniel. I'll check out the patch and apply in the next few days.
Comment #18
phpdiva commentedComment #19
jvieille commentedActually, this does not seem to prevent rss feeds to be published.
I only use this site as a blog, from the admin account.
Feed permissions are not set at all
RSS permissions in admin/settings/rss_permissions are set to "Disable altogether", but the page
www.mysite.xx/rss.xml keeps being populated by newly created items, and other subscribing sites continue to get them
rss.xml is ok for anonymous visitors
Am I missing something?
Comment #20
phpdiva commentedSorry, but I couldn't get to this for the longest time. I'm going to look at this and get something into the dev version by next Friday.
Comment #21
jmcerda commentedsubscribing
Comment #22
jvieille commentedThanks!
This would be really helpful
Comment #23
phpdiva commentedThe fix for this is now in the dev version of the module. If anyone wants to download and test, that would be greatly appreciated.
I want to take close out #954790: Suppress feed icon in themes that override theme_feed_icon() before making a new release of the module.
Comment #24
jmcerda commentedSo where is the new dev version we can download and test?
Comment #25
phpdiva commented@freighthouse, go back to the project page: http://drupal.org/project/rss_permissions.
It's at the very bottom under the "Development releases" with the pink background, called "6.x-1.x-dev".
Comment #26
jmcerda commentedSorry, Im blind. Thank you.
Comment #27
jvieille commentedMay be I don't understand the purpose of this module, but whatever I set the site/rss.xml page is available without restriction.
(see #19)
Thanks
Comment #28
Ela commentedsame as #27
Comment #29
phpdiva commented@jvieille and @Ela,
Are you using the DEV version of the module? Which version of Drupal are you using? Did you clear caches after the install and configuration?
Comment #30
Ela commentedI used .dev version. I was still able to click on rss feed icon, which showed both in firefox and IE. Then after clicking in IE I had "Page Not Found", while using Firefox, I got "not authorized to see this page" error.
Basically same as in post #7
Using the latest Drupal 6.19
I thought that in general, when I run update.php caches are cleared on the site.. If that's not true, then maybe that was my problem..?
Comment #31
phpdiva commented@Ela,
So looks like the actual page gets disabled, but the feed icon still shows up? Are you talking about the icon on the page or in the address bar window. Do you still see the icon if you temporarily switch to one of Drupal default themes, like Garland?
I think the icon issue might be related to #954790: Suppress feed icon in themes that override theme_feed_icon(), if a custom theme you're using is overwriting it. I'll try to get that fix into DEV before the holidays.
Comment #32
Ela commentedHello, :) Yes, that's how it looks (that the actual page gets disabled, but the icon feed still shows). The icon shows in the address bar window. Plus, when I look at the html source of the page, there is a link to it as well. I am using a custom theme (iTheme). I will try to switch to Garland tonight and see if it makes any difference.
Comment #33
jiakomo commentedHello,
I have "disable altogether" option enabled, however there are links to the feeds in the html source code of pages and icons are displayed (I'm talking about the icons in the browser address bar). When clicking the icons, I get "Access denied You are not authorized to access this page." message. It's the same when I use "use permissions" and I remove permissions from users to access site and taxonomy rss feeds.
Is this the expected behaviour, because I thought no rss links would be in HEAD.
I'm using latest -dev of rss permissions and drupal 6.20.
Comment #34
phpdiva commentedHi @jiakomo,
Does it work for you with all custom themes and modules enabled? Most of the time the issues appear when this module is interfering with other ones. Can you test with just a default Drupal theme and no other modules?
Comment #35
Ela commentedI'm sorry I never posted an update. It's because I left the site running as is for now with RSS feeds.
Comment #36
jiakomo commentedphpdiva,
thanks for your reply.
I tried testing with default themes and then with modules and I found out that when I disable the nodewords module, then there is no rss links in the source (which, now I understand, is the expected behaviour of rss permissions module :) )
This is too bad for me, because I cannot afford to have nodewords disabled permanently :(
Comment #37
phpdiva commented@jiakomo, yup, sounds like this is incompatible with nodewords. Which kind of makes sense, since they are rewriting the head of the page. Maybe make a patch or feature request for that module to check if this module is enabled, and use permissions?
Comment #38
leszek.hanusz commentedsubscribing
Comment #39
Leeteq commentedSubscribing.
Comment #40
phpdiva commentedI again apologize to everyone for not addressing the issue in a timely manner. I am changing career paths, and am unable to continue maintaining this module. This module is very small and rather uncomplicated, but it plugs a very important shortcoming in the Drupal core (until that is fixed). Please contact me if you would like to take over this module.
Comment #41
yannickooOh, no activity for 8 months...
I will create a new module soon (I'll post the link here) so that it's possible to disable the RSS functionality completely. And no worry, I will mention the maintainer of the RSS Permissions module ;)
Comment #42
Robin Millette commented@yannickoo You could ask for maintainership of this module instead of creating a new one, no?
Comment #43
yannickooGood point Robin, I'll contact the maintainer. So the module just gets a new option to completely disable the RSS feeds.
Comment #44
Honestly Illustrated commentedLook for similarities here #1349530: Investigate hooks to see if RSS feeds can be disabled fully through module and also consider 6.x's end-of-life looming.