I've found that having this module installed at the same time as Thickbox module has a tendency to break many Thickbox-related things on the site. For instance the "Close or ESC" bar appears 2 times at the top of every thickbox window. Users may often have Thickbox for other requirements on their site (and cannot remove it). An example is Imagecrop module which only calls up the Thickbox mode if the real Thickbox module is installed.

You should make the Thickbox module a required dependency of this module and remove thickbox.js and thickbox.css from your module. Then users can install the regular thickbox module and not have duplicate code causing bugs. This is the recommended way for modules to work together in Drupal.

All you should have to do is remove the current code that calls up the 2 files, and add this line to your .info file:

dependencies[] = thickbox

I tested by commenting out the lines which include the thickbox.js and thickbox.css files, cleared my browser cache, and all Thickbox related issues I was having were fixed.
Thanks!

Comments

gooddesignusa’s picture

gooddesignusa commented

watching this one

frjo’s picture

frjo commented

Adding a dependency is absolute the right thing to do.

I would however suggest you take a look at the Colorbox module as an more modern alternative to Thickbox.

http://drupal.org/project/colorbox

I'm the maintainer of Thickbox and co-maintainer of Colorbox. My plan is to offer Colorbox as an upgrade path for Thickbox user.