Hi,
I've just updated from 6.x-1.3 to 6.x-2.x-dev (2010-Mar-19 ).
In 6.x-2.x-dev, I cannot set the permissions. I cannot see them on admin/user/permissions.

In the file supercron-main.inc, line 197, I had to put ' like this:

  return array('SUPERCRON_ADMIN_PERMISSION', 'SUPERCRON_EXCEPTION_FEED_PERMISSION');

I haven't made a patch because I think this is not a nice name for the permissions and maybe it would be better to change them in the whole module. I mean that other permissions use small letters, not capitals, and have spaces instead of underscore (_).

I'll continue testing the 2.x-dev...

Thank you

Comments

j0nathan’s picture

j0nathan commented

I think all access arguments defined in files (at least supercron-main.inc) will need apostrophe (') too.
Like this:

    'access arguments' => array('SUPERCRON_ADMIN_PERMISSION'),

I was not able to access admin/settings/supercron with permissions, so I used user 1.

lucidus_neil’s picture

lucidus_neil commented

it appears to me that these are constants defined in supercron.inc. If you add in single quotes to everything, you'll notice that the permissions screen (/admin/user/permissions) goes from a relatively attractive 'administer supercron' to SUPERCRON_ADMIN_PERMISSION. I should note that I'm having the same problem with the permissions disappearing but I just don't think the quotes is the issue.

MisterSpeed’s picture

MisterSpeed commented

This is probably related to the use of function_exists in the bootstrap phase; the newer version (to be committed in a few days) gets rid of that mechanism entirely.

We use constants everywhere so as to avoid symbolic duplications and the possibility of transcription bugs or inconsistent use. In the new version, the constants are defined as part of the object accessing the variables table, so the whole issue should be gone.

MisterSpeed’s picture

MisterSpeed commented
Status: Active » Fixed

Should be fixed in the latest release; if not pls re-open. Thanks !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.