Any plans for a Drupal 7 release / upgrade / version ?

subscribe

Drupal 7 version is already in the making (HEAD), see http://drupalcode.org/viewvc/drupal/contributions/modules/tagadelic/?pat...

Although the Drupal 7.x branch has been created, it doesn't look like any development has happened there yet.
Still - it should be an easy port - the tagadelic module is small and quite neat. I might have a look at it myself tomorrow.

For all who want to give it a try: Converting 6.x modules to 7.x, and Coder module is already available for Drupal 7 ;-)

The biggest challenge is that taxonomy is handled in a completely different in D7 than in D6 - taxonomy terms are now fields attached to nodes rather than relationships stored in term_node_data. So, all the tagadelic queries will have to be rewritten, and functions such taxonomy_node_get_terms() don't exist any more.

development happens on github. Keeping CVS to a bare minimum.
Feel free to join there and push patches.

Here it is: http://github.com/berkes/tagadelic

For those of us that don't do git, can you confirm that the version linked in the last post is the same as HEAD in CVS?

Attached patch converts current tagadelic HEAD to Drupal 7. I've given it a quick test against D7-alpha3 and I think it's safe and feature-complete, but it would be helpful if people could download and try to test it more thoroughly - almost all of the queries had to be completely rewritten, together with changes to the theme functions etc. mean there's quite a lot of scope for error!

And, for those who don't/catch apply patches, here's the same file in .zip format. Please test away...

Wow, that looks great on first glance. (I'm not sure the .project file that crept in really belongs.)

I am travelling for some time, so will not be able to look at this thoroughly. Some things that need reviewing:
* code style. Is it implemented clean enough, does it not introduce new clutter, hacks or uglyness. Current code is far fromperect, lets not make it worse.
* benchmark. Tagadelic has performance issues, if not done well. Lets not make things worse: run trough AB to see the numbers.
* Test on large tagsets.
* Test on old sites. e.g upgraded from back in the 4.x days.
* Test on sites with access systems. Tagadelic does not work well with these, now, lets not make things worse.

#12 - @DanielNolde is correct. I always forget which DBTNG methods can be chained and which can't!

I'm not sure if chaining methods where possible makes any difference to performance, but I can confirm that your solution of not chaining at all fixes the problem.

in add to #12 and #14: I am a fan of chaining, provided the language supports it properly. IMHO PHP does not.
So lets steer away from it. And go for the simpler (yet more verbose) route in #14.

Attached a new version with the code style fixed and the DBTNG fatal error fixed.

Admit: I don't know how to create a patch! But, here is a quick fix for tagadelic_page_list(), which calls theme_tagadelic_list_box($variables), which calls theme('box', $vocabulary->name, $content)...which is obsolete in d7.

/**
 * Menu callback renders a tagadelic page with listed items: each voc
 */
function tagadelic_page_list($vocs) {

  if (!$vocs) {
    return drupal_not_found();
  }

  $tags = tagadelic_get_weighted_tags($vocs, variable_get('tagadelic_levels', 6), variable_get('tagadelic_page_amount', '60'));
  $tags = tagadelic_sort_tags($tags);

  $output = theme('tagadelic_weighted', array('terms' => $tags));

  if (!$output) {
    return drupal_not_found();
  }
  
  $vocabularies = taxonomy_vocabulary_load_multiple($vocs);
  foreach ($vocabularies as $vocabulary) {
    $names[] = $vocabulary->name;
  }
  $vocab_names = implode(', ', $names);

  $stylesheet = drupal_get_path('module', 'tagadelic') . '/tagadelic.css';
  drupal_add_css($stylesheet, 'all');
  drupal_set_title($vocab_names);
  
  $output = "<div class=\"wrapper tagadelic\">$output</div>";
  return $output;
}

Thanks for the code! You might have a look at http://drupal.org/patch

subscribe

Hi all,

First of all, I forgot to return here after I ported this module to D7. Currently it's working on my alpha6 site, a almost released site. Then when I thought to return my quick ported module. There already this thread.
The problem is, I don't have much time to look what we already have here. So should I attach my ported version here? For the community to review? I think I got everything working fine on mine.

Please see the work at http://github.com/mscharley/tagadelic/tree/DRUPAL-7--1

suscribe

using http://github.com/mscharley/tagadelic/tree/DRUPAL-7--1
tag clouds work fine.

when going to a term page (taxonomy/term/id) i get WSOD with the following error:
[Tue Nov 23 12:21:51 2010] [error] [client ::1] PHP Fatal error: [] operator not supported for strings in /mysite/includes/common.inc on line 2266, referer: http://mysite/

#21 works fine for me for creating the tag cloud in blocks

No release at project page? Also no dev version?

reopening according to #26

https://github.com/berkes/tagadelic/tree/DRUPAL-7--1

Ok, thanks. I'll try it but why no release here at drupal.org?

Since there is no drupal 7 version on d.o (and thus I couldn't make a normal bug report) please excuse me for hijacking this report.

On line 321 of the Drupal 7 version on github the class of the url is given as a string:
'class' => "tagadelic level$weight",

While it should've been given as an array like this:
'class' => array("tagadelic level$weight"),

The string way (as is used now) will give a fatal error when the link is active (when showing the cloud block on the taxonomy pages).

Class vs string issue moved to #1046056: D7: Class should be an array, not a string..

sub

Hi everybody,

I'm posting this issue here, because there is not channel to post it. Basically, I'm using the Tagadelic module and I'm getting this two errors:

Notice: Undefined index: terms in theme_tagadelic_weighted() (line 314 of /var/www/clients/client1/web4/web/sites/all/modules/tagadelic/tagadelic.module).
Warning: Invalid argument supplied for foreach() in theme_tagadelic_weighted() (line 317 of /var/www/clients/client1/web4/web/sites/all/modules/tagadelic/tagadelic.module).

does anybody know what is going on?

PD: Using D7 Tagadelic and Cumulus modules.

This issue is closed. Please open a new ticket for new issues. However, your issue was reported and dealt with AFAIK. So please search to find if you can contribute to an existing issue.

Hi,

I have exactly the same issue than Campeon38, #34, but I couldn't find a solution yet. I installed the Berkes' version, and I can see the cloud working fine, still I got hat message from Drupal...

Would be able to advice me please?

Thank you for your help.

Best regards,
Richard.

please do not re-open issues, unless you have detailed and solid information it is actually the same bug re-appearing.