Clean up aggregator css styles [#749530]

Comment	File	Size	Author
#9	aggregator2.patch	760 bytes	dodorama
#5	aggregator.patch	2.24 KB	dodorama
#1	aggregator.patch	1.54 KB	dodorama

Comment #1

dodorama commented 23 March 2010 at 21:02

Status:

Needs work

» Needs review

Status	File	Size
new	aggregator.patch	1.54 KB

The patch!

Log in or register to post comments

Comment #2

sun

German

Karlsruhe

commented 23 March 2010 at 21:16

Removing the file(s) should automatically make them appear in your patch as removed.

Log in or register to post comments

Comment #3

dodorama commented 25 March 2010 at 00:49

Strange. I removed the files but there's no mention of them in the patch.

Log in or register to post comments

Comment #4

retester2010 commented 25 July 2010 at 10:22

Status:

Needs review

» Needs work

+++ themes/garland/style.css	22 Mar 2010 15:39:32 -0000
@@ -818,6 +818,11 @@ ul.links li, ul.inline li {
+#aggregator .feed-source .feed-icon {
+  float: right; /* LTR */ ¶
+  display: block;

trailing white space

40 critical left. Go review some!

Log in or register to post comments

Comment #5

dodorama commented 26 July 2010 at 14:48

Status	File	Size
new	aggregator.patch	2.24 KB

I decided to remove even the last bit of CSS. Without that float declaration we don't lose any functionality. So basically I removed the 2 css files and any mention to them in the module init hook.
Less CSS styles to overwrite!

Log in or register to post comments

Comment #6

dodorama commented 26 July 2010 at 14:51

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #7

sun

German

Karlsruhe

commented 26 July 2010 at 17:14

hm, removing everything? I guess that some of these styles apply to the administrative pages, perhaps? We definitely need before/after screenshots here.

Log in or register to post comments

Comment #8

jacine

she/her

New York

commented 26 July 2010 at 18:39

Component:

aggregator.module

» markup

Log in or register to post comments

Comment #9

dodorama commented 27 July 2010 at 11:04

Status	File	Size
new	aggregator2.patch	760 bytes

A softer approach with screenshots.

Original code

/* $Id: aggregator.css,v 1.3 2010/04/28 20:08:38 dries Exp $ */

#aggregator .feed-source .feed-title {
  margin-top: 0;
}
#aggregator .feed-source .feed-image img {
  margin-bottom: 0.75em;
}
#aggregator .feed-source .feed-icon {
  float: right; /* LTR */
  display: block;
}
#aggregator .feed-item {
  margin-bottom: 1.5em;
}
#aggregator .feed-item-title {
  margin-bottom: 0;
  font-size: 1.3em;
}
#aggregator .feed-item-meta,
#aggregator .feed-item-body {
  margin-bottom: 0.5em;
}
#aggregator .feed-item-categories {
  font-size: 0.9em;
}
#aggregator td {
  vertical-align: bottom;
}
#aggregator td.categorize-item {
  white-space: nowrap;
}
#aggregator .categorize-item .news-item .body {
  margin-top: 0;
}
#aggregator .categorize-item h3 {
  margin-bottom: 1em;
  margin-top: 0;
}

With patch applied

/* $Id: aggregator.css,v 1.3 2010/04/28 20:08:38 dries Exp $ */

#aggregator .feed-source .feed-title {
  margin-top: 0;
}
#aggregator .feed-source .feed-image img {
  margin-bottom: 0.75em;
}
#aggregator .feed-source .feed-icon {
  float: right; /* LTR */
  display: block;
}
#aggregator td {
  vertical-align: bottom;
}
#aggregator td.categorize-item {
  white-space: nowrap;
}
#aggregator .categorize-item .news-item .body {
  margin-top: 0;
}
#aggregator .categorize-item h3 {
  margin-bottom: 1em;
  margin-top: 0;
}

I don't know if #aggregator .categorize-item .news-item .body, #aggregator .categorize-item h3 and #aggregator .feed-source .feed-title are used anywhere, I couldn't find any mention in code. In doubt I left those.
Since Garland override these styles nothing changes there, thus no screenshot.