The attached patch allows an admin to specify a set of roles that should always be forced onto https, regardless of which path they're accessing.

This allows you to (for instance) easily specify that all authenticated users should always use https.

CommentFileSizeAuthor
#6 750104-securepages-by-role-6.patch3 KBcafuego
#3 securepages-750104-3.patch2.97 KBsime
#2 securepages-by-role-2.patch2.97 KBcafuego
#1 securepages-by-role.patch3.03 KBcafuego
securepages-by-role.patch2.92 KBcafuego

Comments

cafuego’s picture

cafuego commented
StatusFileSize
new securepages-by-role.patch3.03 KB

I boo-booed in the patch and left a debug statement in. Removed in this version.

This version also works and doesn't match user roles against roles for which https enforcement is not enabled.

cafuego’s picture

cafuego commented
StatusFileSize
new securepages-by-role-2.patch2.97 KB

Yet another version. I found array_filter(), so there's no need for a foreach() loop to clean up the enabled roles.

sime’s picture

sime
any/any
Location Melbourne
commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new securepages-750104-3.patch2.97 KB

This works, new rolled patch with a smidge more info for the admin form.

dboulet’s picture

dboulet commented

Would like to see this implemented in 7.x as well.

izmeez’s picture

izmeez commented

subscribing

cafuego’s picture

cafuego commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 750104-securepages-by-role-6.patch3 KB

Minimal effort to port the patch to 7.x-1.x

dboulet’s picture

dboulet commented

Patch in #6 looks good to me.

grendzy’s picture

grendzy commented
Assigned: Unassigned » grendzy
khaled.zaidan’s picture

khaled.zaidan commented

Can we expect this to be committed to both 6 and 7?

thx

grendzy’s picture

grendzy commented

Yes, I'm hoping to get this in the next release.

grendzy’s picture

grendzy commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

With a few edits, and added tests, this has been committed to 7.x: 4b8f953.

Moving to 6.x.

grendzy’s picture

grendzy commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
Status: Patch (to be ported) » Fixed

Committed to 6.x-2.x branch. http://drupalcode.org/project/securepages.git/commit/4634850

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.