I only want my users to be able to login with twitter and connect there accounts so that they're able to login. I have set 'Import Twitter statuses' to off, but when a user connects their account it still has an option to 'import'.

Also, 'import' is a very poor term to be used; users won't know what 'import' means and it should read 'import tweets' or have some type of explanation.

CommentFileSizeAuthor
#5 twitter-750156-do_not_offer_import_if_disabled_sitewide.patch3.07 KBxurizaemon

Comments

j0k3z’s picture

j0k3z commented
Component: Documentation » User interface
Category: support » bug

I agree.

I use the Twitter module ONLY for posting updates. I have disabled the "import" checkbox in the settings but when a user adds a twitter account not only does it show them the "import" checkbox, it defaults to being checked -- very confusing for my users.

Im changing this to a bug report because I beleive the settings checkbox should disable the one shown to users but I guess its not working.

j0k3z’s picture

j0k3z commented

Any updates regarding this?

j0k3z’s picture

j0k3z commented

I noticed in the code it says

We'll fix this in the next reshuffling when user account
  // management gets an overhaul

So when you overhaul it I think it would be nice to hide the "import" and also the "private" row as its confusing to end users if this functionality isnt available. Any roadmap or time frame for this overhaul?

As If’s picture

As If commented

You can remove the checkbox by commenting out lines 132-135 of twitter.pages.inc:

  /* 
  $form['import'] = array(
    '#type' => 'checkbox',
    '#default_value' => $account->import,
  );
  */

This doesn't remove the column header, but it does remove the chance of someone using it ;-)

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Title: Very confusing - can we not turn 'import' off? » Do not offer option to import tweets when import disabled sitewide
Version: 6.x-3.0-beta2 » 6.x-3.x-dev
Status: Active » Needs review
StatusFileSize
new twitter-750156-do_not_offer_import_if_disabled_sitewide.patch3.07 KB

Try this patch, which checks the sitewide value and respects it on the user Twitter edit screen.

juampynr’s picture

juampynr commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Needs review » Fixed

Applied grobot's patch.

http://drupalcode.org/project/twitter.git/commitdiff/efdf3c032910af34917...

You can download the latest dev release tomorrow, or wait until next week for the next beta release.

Cheers

PD: I am porting the patch to the Drupal 7 version.

juampynr’s picture

juampynr commented

Applied on 7.x-3.x.

http://drupalcode.org/project/twitter.git/commitdiff/e9359c1449491085d76...

Cheers

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.