I have modified the code to add option in the configuration page to disable the next & prev button, change the time limit before scroll for the automatic scrolling, Limit the character shown for the title and limit the character shown for the body

CommentFileSizeAuthor
scrollable_content.zip4.48 KBduckzland

Comments

good_man’s picture

good_man commented
Status: Active » Needs work

Hi,

Thanks for the good work, but for limiting the characters and more of that I prefer to left this job to Views module, let's try to keep it as simple as possible, the other features are pretty good.

I'll include them in the next release.

duckzland’s picture

duckzland commented

No problem, glad I can provide help to this great community.

cheers!

good_man’s picture

good_man commented

Can you check the new 2.x release? hope everthing is better now. Thanks again.

duckzland’s picture

duckzland commented

Just checked the version 2.0 of the module. It is better module than the previous version in terms of code structure :)

got a question though :

print $classes; ">

-> what does it do? I remove this and the module still working or I am missing something?

overall great job for the new version.

cheers.

good_man’s picture

good_man commented

I didn't understand your question well, in which line and what changes you made?

good_man’s picture

good_man commented
duckzland’s picture

duckzland commented

sorry seems that the code is not shown in the comment


<div class="navi <?php print $classes; ?>"></div>

that is the code in questions.

good_man’s picture

good_man commented

This $classes variable will hold a unique class for each theme you use, this way you can use the new theming feature in 2.x, also to show multi-scrollables in the same page without CSS collisions.

duckzland’s picture

duckzland commented
Version: 6.x-1.2-beta3 » 6.x-2.0-beta2
Category: feature » bug
Priority: Minor » Major
Status: Needs work » Needs review

Dude, I found problem in IE7, seems that IE doesn't like "," in the js before closing }).

function scrollable_content_build_js_code($options) {
  $js = "\$(function() {\n";

    $js .= "\$(\"#scrollable_content_" . $options['items'] . "\").scrollable({\n";
      $js .= "  keyboard: " . $options['keyboard'] . ", \n";
      $js .= "  mousewheel: " . $options['mousewheel'] . ", \n";
      $js .= "  circular: " . $options['circular'] . ", \n";
      if (!$options['direction']) {
        $js .= "  vertical: true, \n";
      }
      $js .= "  speed: " . $options['speed'] . " \n";
    $js .= "})";

    if ($options['navigator']) {	
			if ($options['history'] && 0) {
	  		$js .= "  history: " . $options['history'] . " \n";
			}
      $js .= ".navigator({\n";
        $js .= "  navi: \"#scrollable_content_" . $options['items'] . "_navi\", \n";
	//$js .= "naviItem: 'a', \n";
        $js .= "  activeClass: 'scrollable_content_active' \n";


      $js .= "})";
    }

    if ($options['autoscroll']) {
      $js .= ".autoscroll({\n";
        $js .= "  interval: " . $options['interval'] . ", \n";
        $js .= "  autoplay: " . $options['autoplay'] . ", \n";
        $js .= "  autopause: " . $options['autopause'] . " \n";
      $js .= "})";
    }

    $js .= ";\n";

  $js .= "});";

  return $js;
}

modifying the order of the options and removing the last element "," seems fixed the problem.

good_man’s picture

good_man commented

Thanks for that, I don't have windows on my machine rightnow, so I'll publish these changes in the next release.

duckzland’s picture

duckzland commented

got another bug :

"Number of results to get cannot be longer than 1 characters but is currently 2 characters long." error message popping up when u select "Number of results to get: " to 10 or more

good_man’s picture

good_man commented

Thanks for that! but what's the problem with that error? I mean it's set to 9 results max, is that limitation annoying?

duckzland’s picture

duckzland commented

no it's not the 9 result limit, but the select box is showing more than 9 options, if we want to limit the user to choose up to 9 results then I think the select box should only show 0-9 as the options

good_man’s picture

good_man commented

ah I see now, btw I don't know why I set that stupid option :D

good_man’s picture

good_man commented
Status: Needs review » Active

So any bugs still occurs in 6.2 BETA 3?

marianojofre’s picture

marianojofre commented

Thanks a lot!

I have the ie7 error with 6.2
In 6.x-1.2-beta3 the problem is solved.

What can I do to solve the issue in ie7 for 6.2 beta 3?