Closed (fixed)
Project:
Click Thru Tracking
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
23 Mar 2010 at 17:20 UTC
Updated:
20 Apr 2010 at 14:10 UTC
Here are patch files to make this module ready for Druapl 6.
I have created patches for all the files, (./info, .install .module), and have uploaded them.
I have installed this on my drupal 6 development site, and it works fine.
Please let me know your thoughts, and if it needs any more work.
| Comment | File | Size | Author |
|---|---|---|---|
| click.module.patch | 3.93 KB | kpbowler | |
| click.install.patch | 2.17 KB | kpbowler | |
| click.info_.patch | 521 bytes | kpbowler |
Comments
Comment #1
kpbowler commentedSorry, I didn't describe much about what I did here, the excitement of submitting my first patch was too much!
I followed the guide here http://drupal.org/node/114774 to convert this module from Drupal 5 to Drupal 6.
I implemented the hook_schema, changed the hook_menu to work with Drupal 6 and various other small changes.
If there is something I have missed out, please let me know and I'll fix ASAP.
PS This is a great module, I'm really happy I could contribute, I just hope it helps!
Kev.
Comment #2
kbahey commentedActually, there seems to be a release since Sept 2008, but it was not showing on the project page.
My mistake. I made it visible now here http://drupal.org/project/click
Please download that release and test it.
Sorry about the time wasted, but hope it was a good introduction to contributing to Drupal.
Please do continue to contribute.
Comment #3
kpbowler commentedNo worries, it was very useful! I would be interested in looking at a D7 conversion if you want? I think my work will want to use this module for the long term.
Comment #4
kbahey commentedYes, that would be needed too.
Go ahead and use the 6.x-1.x-dev as a base for that, and do the D7 conversion.
Will commit once you confirm it is working, and you provide patches.
Thanks again.
Comment #5
kpbowler commentedHi, I have been using this module for a while now on a production site with no issues to report. What other checks need to be carried out before this development version can be marked as 1.0?
Comment #6
kbahey commentedDone.
Should appear here shortly http://drupal.org/node/763408