If I try to rearrange the display order of blocks (that is to say which order they are displayed from top to bottom in a column) via Context inline editor, the blocks disappear after saving. In order to restore them, I have to delete the context and build it from scratch. Not fun.

Comments

yhahn’s picture

Status: Active » Postponed (maintainer needs more info)

What version of PHP are you using?

fm’s picture

PHP 5.2.9

mstef’s picture

I can't even find how to turn on the inline editor..

kyle_mathews’s picture

@mikesteff you need to install the admin module.

mstef’s picture

Yea I did...and jQuery UI..didn't notice you have to enable the editor in the admin settings first...

Thanks

my-family’s picture

Please could you tell me where to enable the editor? I see nothing similar at admin/settings/admin (have jQuery UI and Admin module). Thank you. (EDIT: bad version of jQery: 1.6 is necessary, after that the checkbox "Context editor" appeared at admin/settings/admin).

fm’s picture

Just curious if you'll be getting back to me about this sometime soon. I realize you're busy.

my-family’s picture

Version: 6.x-3.0-beta4 » 6.x-3.x-dev

I can confirm that after saving changes via inline editor, some blocks disappeared (e.g., default block for user log-in and registration). Additionally (maybe this should be a separate issue?), after adding block to one context, block weights in another context are affected.

I use PHP 5.2.13

adamdicarlo’s picture

Status: Postponed (maintainer needs more info) » Active

@yhahn,

I can confirm this on 6.x-3.0.

I believe the problem is that certain blocks appear blank sometimes (user login block when you're logged in), and when that's the case, saving the context saves it without the (currently blank) blocks, thus removing them from the context.

Steps to reproduce:

  1. Add user login (user-0) block and any other blocks to a context.
  2. Use Context Inline Editor to edit the context from step 1.
  3. Without necessarily changing anything, simply save the context.

I presume that's enough information so I've changed the status back to Active.

If you're unable to reproduce it, let me know, and I'll try to reproduce it in a specific theme (in case it's theme related). Thanks!

adamdicarlo’s picture

Ah ha -- I only thought I was using 3.0, but was still on beta5 for the site I saw this problem on. No more disappearing blocks with 3.0. Sorry about the confusion!

doublejosh’s picture

I recently updated to 3.0 and have seen the appearance of what I think is some content editor code for all users.
I do not have admin installed, and don't really want the context editor.

This is appeared in the header region, nothing else showed up anywhere else...
<a id="context-block-region-header" class="context-block-region">Header</a>

adamdicarlo’s picture

@doublejosh, I think you should create a new issue for that.

This issue, as far as I can tell, is completely fixed. I'll let the maintainers mark it as such though.

doublejosh’s picture

I solved this by enabling then disabling "show all regions" ... so perhaps this was some kind of caching issue.

mrfelton’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev

This happens to me all the time with context 3 and drupal 7. Whenever you use the context inline editor on a page that has blocks with no content in that context, those blocks with no content get removed from the context when you save the edited context.

mrfelton’s picture

I believe the problem is because is_editable_check() only sets the context_ui_editor_present context if the context_ui-editor block has been placed in a region. I have been using context for years, but have never placed that block in a region, because I use it in conjunction with admin.module. if admin.module renders the context_ui-editor block then that should also trigger the context_ui_editor_present - which would prevent this problem.

mrfelton’s picture

Version: 7.x-3.x-dev » 6.x-3.x-dev

My issue was actually partially resolved by upgrading to the latest 7.x of admin and context, and fully resolved using #1401964: Empty blocks are always show to admins when using the context inline editor. Setting this back to 6.x.

mrfelton’s picture

Actually, I take back my comment from #16. The attached patch fixes the issue that I described in #15 and ensures that the context_ui_editor_present context is set when the context_ui-editor is rendere by admin.module. It's not the prettiest patch, but t least it means I can use context without having blocks going missing all the time (patch is for D7).

tekante’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev
Status: Active » Needs work

Tried the patch from #17 and it appears to partially resolve the issue. Empty blocks that are already placed don't disappear when using the inline editor from the admin module toolbar but empty blocks can't be added. You may want to take a look at the patch in #1050724: Context UI Revamp which allows access to the inline editor without having to place it in a region or use the admin module toolbar.

ianthomas_uk’s picture

Priority: Normal » Critical

The following are all dupes for specific cases of this issue:

http://drupal.org/node/996426
http://drupal.org/node/1076706 (fixed in 7.x-3.0-beta4)
http://drupal.org/node/1251406
http://drupal.org/node/1933930

Setting status to Critical as it causes loss of data (i.e. which blocks are mapped to a context). If the patch in #17 fixes the data loss without regressions then I'd be tempted to commit it and follow up #18 later (which on its own would only warrant a Normal status).

ianthomas_uk’s picture

Please see http://drupal.org/node/996426#comment-5220200 for a patch with an alternative solution