The following error occurs when submitting the subscriptions_content.module activation in settings ( url: http://example.com/admin/build/modules/list/confirm)

Parse error: parse error, unexpected T_OBJECT_OPERATOR in ~/sites/all/modules/subscriptions/subscriptions_content.module on line 577

Following which it is not possible to access the site without either deactivating the module in the database or by removing the module from the server directory.
This occurs both on an upgrade to and on a separate fresh install of Drupal-6.16 (I do have a number of other contributions installed)

I note (here: http://drupal.org/node/717336 ) the following recent enhancement for release 1.2
- #401298: Make subscriptions revision-aware?: Provide !revision_name and !revision_log variables.

I also note that the error (line 577 and 588) is as follows:

  $mailvars['!revision_name'] = subscriptions_user_load($node->revision_uid)->name;   
  $mailvars['!revision_log'] = _subscriptions_content_format_text($node->log);

It is possible to activate the module only by commenting out line 577 following which the modules activates and the relevant content options are added to the settings page. I have not tested beyond that.

Comments

salvis’s picture

salvis
he/his
commented

I'm not seeing this there, neither with Drupal 6.15 nor 6.16. What's your version of PHP?

netlynx’s picture

netlynx commented

PHP Version 4.4.2

salvis’s picture

salvis
he/his
commented
Priority: Critical » Normal

The recommended version is 5.2.x, as per http://drupal.org/requirements

Yes, you can comment out line 577 and run Subscriptions that way. Is there a problem with the other line, too?

salvis’s picture

salvis
he/his
commented
Status: Active » Postponed (maintainer needs more info)

Please try replacing

  $mailvars['!revision_name'] = subscriptions_user_load($node->revision_uid)->name;

with

  $account = subscriptions_user_load($node->revision_uid);  
  $mailvars['!revision_name'] = $account->name;

Does that fix the problem?

I assume that's your line 577. Why are you also mentioning line 588? Or did you mean line 578? Is something wrong with that line, too?

guignonv’s picture

guignonv
Primary language French
Location Montpellier
commented

Hi! I had the same problem described above and I tried replacing the line 577 by the 2 lines you provided and it solved the problem on my server. Thanks!

My conf: Drupal 6.16, PHP 4.3.9, Subscription 1.2.

salvis’s picture

salvis
he/his
commented
Status: Postponed (maintainer needs more info) » Fixed

Great, thanks for letting us know.

Committed to the -dev version.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.