Drupal.org
Drupal.org CVS applications » Issues

gege2061 [gege2061]

Posted by gege2061 on March 24, 2010 at 2:55pm
Project:Drupal.org CVS applications
Component:Miscellaneous
Category:task
Priority:normal
Assigned:kiamlaluno
Status:closed (fixed)
Issue tags:module review

Issue Summary

CVS edit link for gege2061

Hello,

This is my first Drupal module. It adds a flag for mark a forum comment accepted and the topic as solved.

This is a popular feature supported by many forum scripts but I found nothing for Drupal.

Preview : http://gege2061.homecomputing.fr/flag_solved.png
Sources : http://gege2061.homecomputing.fr/flag_solved.tar.gz

Login or register to post comments

Comments

#1

Posted by gege2061 on March 24, 2010 at 3:18pm
Status:postponed (maintainer needs more info)» needs review
AttachmentSize
flag_solved.tar_.gz 3.07 KB

#2

Posted by kiamlaluno on March 25, 2010 at 10:04pm
Status:needs review» needs work

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

#3

Posted by gege2061 on March 26, 2010 at 10:14am

Thank's for your answer.

This module is based on the flag module and allows forum topic author or content administrators to mark a forum comment as "Accepted". Accept a response highlights and adds an image in the topic title.

I have not found this feature in other drupal module, I can't compare.

#4

Posted by gege2061 on March 26, 2010 at 11:02am

Minor changes:

  • Adding comments
  • Improving _flag_solved_advforum_enable (use a static variable)
  • Improving usage without advanced forum module (don't use ajax for flaging)
  • Add js only if necessary
AttachmentSize
flag_solved.tar_.gz 3.19 KB

#5

Posted by kiam on March 26, 2010 at 11:06am

As you reported the module is based on Flag, why didn't you open a feature request in that module queue to integrate the feature in the existing project?

#6

Posted by gege2061 on March 26, 2010 at 1:34pm

The flag module is very versatile. Like flag_abuse, flag a message as solved causes other actions. We can imagine an interaction with the voping_api module for increase the score for an user, for example.

#7

Posted by kiamlaluno on March 26, 2010 at 10:12pm
Status:needs work» needs review

#8

Posted by gege2061 on April 12, 2010 at 8:39am

Adding support for nodecomment

AttachmentSize
flag_solved.tar_.gz 3.26 KB

#9

Posted by gege2061 on April 13, 2010 at 7:25am

fixed many bugs.

AttachmentSize
flag_solved.tar_.gz 3.32 KB

#10

Posted by kiamlaluno on May 25, 2010 at 7:29pm
Assigned to:Anonymous» kiamlaluno

I will review the code tomorrow.

#11

Posted by kiamlaluno on May 27, 2010 at 9:01am
Status:needs review» fixed

#12

Posted by System Message on June 10, 2010 at 9:10am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here