Update directly adds ui files and is broken by 1.8 update [#751752]

update.manager.inc has the following problematic code.

  drupal_add_css('misc/ui/ui.all.css');
  drupal_add_css('misc/ui/ui.dialog.css');
  drupal_add_js('misc/ui/ui.core.js', array('weight' => JS_LIBRARY + 5));
  drupal_add_js('misc/ui/ui.dialog.js', array('weight' => JS_LIBRARY + 6));

This is broken by the UI 1.8 update since it doesn't use drupal_add_library(). I don't see any side effects and can't find where the dialog or UI code is actually used. I suspect it was probably a precursor to #613654: update.manager.js is missing that has since been outdated and not updated. I think we should probably remove it and follow up with 613654 and have it add it back correctly.

Comment	File	Size	Author
#3	751752.patch	633 bytes	neclimdul
#2	751752.patch	804 bytes	neclimdul

Comments

Comment #1

dww

we/he/they

commented 26 March 2010 at 03:52

Status:

Needs review

» Needs work

That sounds fine to me. I don't remember adding any of that code. CVS blame points to revision 1.1, so it must have been one of those things that I didn't fully grok or even notice. jQuery and CSS are some of my weaker points, so I tend to wave my hands at those.

Anyway, sure. A patch to remove those 4 lines should be fine, then we can fix all this over at #613654.

Thanks,
-Derek