We probably need to have admin settings for the 'username' field to allow/disallow username login and also to set the field title, e.g. Username or Email.
With logintoboggan installed and allowing both username and email logins the field title is 'E-mail'.
Since 'user_pass' and 'user_login' both use t('E-mail') a string override cannot do the job.

Perhaps the weight of the logintobbogan needs to be heavier so it can do it's own field title change.

Comments

greggles’s picture

Status: Active » Closed (works as designed)

I think we should keep the number of admin settings as few as possible. It seems that in the 2.5 years since this issue was created nobody else felt that it was an important enough feature to work on it so my feeling is that this should not be added.

This can definitely be done in a site-specific module for anyone who really needs it.