To properly match D7's entity information and to help generalize the code used in Pathauto, we need to rename all the 'pathauto_taxonomy_[vid]_pattern' variables to 'pathauto_taxonomy_term_[vocabulary:machine-name]_pattern'.

CommentFileSizeAuthor
#6 752030-pathauto-taxonomy-pattern-variables-D7.patch4.19 KBdave reid
#5 752030-pathauto-taxonomy-pattern-variables-D7.patch4.18 KBdave reid

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Machine names can get long, right?

I think we might bump up against the 128 character limit on variable names if we do this. Perhaps we need our own variable storage before this issue can be worked on (I think you have an issue for that somewhere, right?).

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

According to the D7 schemas, the machine name is limited to 32 characters, so I don't think we'd be hitting the limit (total length would be 64 and limit is 128 in D7). Ideally we'd be storing these in the DB with the progressive disclosure issue.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Actually the machine name limit is 21 characters, so even better. :)

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Priority: Normal » Major
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 752030-pathauto-taxonomy-pattern-variables-D7.patch4.18 KB

Easier that expected now that a lot of clean-ups and duplication are gone.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 752030-pathauto-taxonomy-pattern-variables-D7.patch4.19 KB

Tested this manually and the upgrade worked great. Revised patch that uses a little less greedy update function if the user doesn't run update.php right away.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed to CVS http://drupal.org/cvs?commit=403836. Changing the base name of 'pathauto_taxonomy_...' to 'pathauto_taxonomy_term_...' is not possible with the current APIs and will be addressed with 7.x-2.x and the progressive disclosure storage.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.