Closed (fixed)
Project:
Drupal.org CVS applications
Component:
new project application
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
24 Mar 2010 at 22:42 UTC
Updated:
26 Oct 2018 at 19:38 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
bkoether commentedAttached are the files of the module.
Comment #2
avpadernoHello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.
As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.
Comment #3
bkoether commentedHere is a more detailed motivation message:
This module has been developed to integrate the image editing services of Picnik (www.picnik.com) with a Drupal installation.
Picnik offers the ability to edit and modify images online without the need of an image editing tool on the users computer.
It allows for resizing, cropping, color adjustments, text overlays and many more image manipulation options.
While there are a number of modules available to manipulate images there is no easy "one-stop" solution that offers all the options Picnik does.
On top of that, the available options of modules target either administrative users or a scripted way of manipulating images (like imagecache). The Picnik service offers a clean and easy to understand interface.
Once the module is enabled and configured editable images display an edit link when hovering over the image. Clicking on the link redirects the user to the picnik interface and loads the selected image in there. After the user has modified the image and clicked on the "Save Changes" the modified image is send back to the drupal site presenting the user with a before/after view. This style of this view can be overridden with theme functions. On the before/after view the user has the final choice to apply or discard the changes.
Imagecache Integration
This module takes into account if an image is processed by imagecache. In this case the original image is send to Picnik for editing.
Upon saving the modified image the module will clear all imagecache versions of the specific file.
Permissions
There are two basic levels of permissions.
Edit Own Images - The user can only edit the images that belong to nodes he/she can edit.
Edit All Images - The user can edit all images even those inside of blocks.
Additionally there is an option to give permissions if a role is allowed to change the module settings.
Settings
It is possible to set a class for images that should not be editable as well as to restrict the HTML area in which the "Edit Own Images" role can edit images (this should be set to the node content area)
I hope this detailed enough.
Ben
Comment #4
avpadernoThanks for the reply; the description is detailed enough, IMO.
Comment #5
bkoether commented@kiamlaluno: Anything changes I have to make to the module to get the CVS access?
Haven't heard anything for almost 2 weeks.
Ben
Comment #6
avpaderno@bkoether: There is nothing more you need to do; somebody should review the code, and report what needs to be changed.
There are many users who can review CVS application proposed modules/themes, and I much prefer to not be the only one to review code, just for the fact to allow a plurality of point of views, which is necessary to avoid to monopolize the application process.
Comment #7
cghobbs commented@kiamlaluno I've reviewed the module and it adheres to Drupal's security standards and coding standards. Approved from my point of view.
Comment #8
avpadernoThere is something that can be changed in the code, but it is nothing that would reject the account approval.
Thank you for your contribution! I am going to update your account.
These are some recommended readings to help with excellent maintainership:
You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
I thank all the dedicated reviewers as well.
Comment #11
avpaderno