Latest version defaulting attribute SKU's to base SKU: No database update or price adjustments

Update: Behaviour is same whether using an attributed product, or an attributed product from a subclass (we are discontinuing subclasses for various reasons)

By looking at a pending order, I can see that the base SKU has been used, not the SKU of the option

Two associated error reports:-
-------------1---------------------------------------------------------
Type php
Date Thursday, March 25, 2010 - 12:52
User jon
Location http://192.168.16.2/?q=admin/store/pos/ajax
Referrer http://192.168.16.2/admin/store/pos
Message in_array() [function.in-array]: Wrong datatype for second argument in /mnt.../uberpos/includes/uberpos.ca.inc on line 100.
Severity error
Hostname 192.168.16.56
Operations

------------end 1---------------------------------------------------

------------2--------------------------------------------------
Type php
Date Thursday, March 25, 2010 - 12:52
User jon
Location http://192.168.16.2/?q=admin/store/pos/ajax
Referrer http://192.168.16.2/admin/store/pos
Message array_keys() [function.array-keys]: The first argument should be an array in /mnt/...uberpos/includes/uberpos.ca.inc on line 100.
Severity error
Hostname 192.168.16.56
Operations

----------end 2--------------------------------

Thanks, slip, I'm going to see if I can pick where it's going wrong, by way of trying to help.

Problem is in this function, but as you can see, is because of a call to module_invoke_all

function uberpos_add_product($input, $order = NULL, $qty = 1, $attributes_extra = NULL) {
  /*
   * If the uc_attribute module is enabled, we need to check to see if the shop
   * owner has created any special skus in on the adjustments page to tie a sku
   * to specific attribute settings.
   */
  if (module_exists('uc_attribute')) {
    $result = db_query("SELECT nid, combination FROM {uc_product_adjustments} WHERE model = '%s'", $input);

    if ($item = db_fetch_object($result)) {
      $attributes = unserialize($item->combination);
      $nid = $item->nid;
    }
  }
  
  /*
   * No adjustment skus, so we just check to see if any products have a sku
   * matching the input.
   */
  if (!$nid) {
    $result = db_query("SELECT nid FROM {uc_products} WHERE model LIKE '%s'", $input);
    $nid =  db_result($result);
  }
  																																																						//watchdog('user','nid value query uc_products is:'.$nid);

  if ($nid) {
    $product = node_load($nid);

    if (isset($product) && node_access('view', $product)) {
      if (!$order) {
        $order = uberpos_add_order();
      }

      $product->qty = $qty;

      if ($qty > 1) {
        $product->title = $qty .'X '. $product->title;
      }

      $product->price = $product->sell_price;

     $product->model=$input;						// Correct assignment of sku

      if (isset($attributes)) {
        if (isset($attributes_extra)) {
          $product->data['attributes'] = array_merge($attributes, $attributes_extra);
        }
        else {
          $product->data['attributes'] = $attributes;
        }
      }
      else {
        if (isset($attributes_extra)) {
          $product->data['attributes'] = $attributes_extra;
        }
      }
						                                                     // at this point sku remains correct
												       watchdog('user','pre module invoke all product->model is:'.$product->model);
      module_invoke_all('cart_item', 'load', $product);
      												      // however, after module_invoke_all statement, sku defaults back to base sku
      												      watchdog('user','post module invoke all product->model is:'.$product->model);
      drupal_alter('order_product', $product, $order);
      uc_order_product_save($order->order_id, $product);

      if (variable_get('uc_order_logging', TRUE)) {
        uc_order_log_changes($order->order_id, array('add' => 'Added ('. $product->qty .') '. $product->title .' to order.'));
      }

      $order = uc_order_load($order->order_id);
      																																																						

      ca_pull_trigger('uberpos_item_added', $order, $product);
      

      return $order;
    }
  }

  return FALSE;
}

from the log:
user 03/25/2010 - 15:19 post module invoke all product->model is:nmLheaXX jon Note - 'XX' indicates the base sku
user 03/25/2010 - 15:19 pre module invoke all product->model is:nmLheatulp jon Note - This value is the correct sku

Hope this helps
I think this is about as far as I can take it, not being privy to the overall design!
Jon

Thanks for the patch.

Informally tested against
1. Attributed items as type product
2. Attributed items as a product subclass
3. Non attributed items
4. Random combinations of the above.

Both decrementation, and incrementation of database appears to be correctly functioning

(I'd not use the word 'appear' except my testing *was* informal!)

Many thanks for the quick fix, Silas

Jon

Happy to help, and hey, that's my first credit for helping fix something. I've a big smile right now!

Todo:
1. Monetary contribution to Uberpos dev overdue :-(
2. Write some useful modules for the community, just like Uberpos.