Pass $subject to the template

I think you are right, mimemail_theme_theme() should pass the $subject as argument to the template. I am willing to test and review your patch if you attach one.

Or maybe you can review mine.

Seems to work fine for me too.
Thanks :)

Here's the same patch that allows the $recipient variable to be passed to the theme function as well. This is very helpful when theming in specific things for the $recipient. (Such as "Premium member" on the header of the e-mail, or "Edit your profile").

When I first started theming, I didn't get that $vars['user'] variable in theme_preprocess_mimemail_message($vars, $hook) was the user who triggered the e-mail to send (in some cases an anonymous user) not the actual recipient. So if user 1 ran cron.php which caused an e-mail to be sent to user 2, $vars['user']['uid'] would be 1. I made the mistake of assuming that $vars['user'] was the recipient, but that is not the case. (But appears to be the case when testing.)

Adding $recipient to the theme_preprocess_mimemail_message function solves that.

My 2 cents.

I don't have access to CVS at the moment, (sorry) but here is the patch:

--- mimemail.module (saved version)
+++ (current document)
@@ -124,8 +124,8 @@
       }
     }
   }
-  $subject = mime_header_encode(trim(drupal_html_to_text($subject)));
-  $body = theme('mimemail_message', $body, $mailkey);
+  $subject = trim(drupal_html_to_text($subject));
+  $body = theme('mimemail_message', $subject, $body, $mailkey, $recipient);
   foreach (module_implements('mail_post_process') as $module) {
     $function = $module .'_mail_post_process';
     $function($body, $mailkey);
@@ -137,7 +137,7 @@
   $headers   = array_merge($headers, $mail['headers']);
   $message   = array(
     'address' => mimemail_address($recipient),
-    'subject' => $subject,
+    'subject' => mime_header_encode($subject),
     'body'    => $mail['body'],
     'sender'  => $sender,
     'headers' => mimemail_headers($headers, $sender),

--- mimemail.theme.inc (saved version)
+++ (current document)
@@ -5,7 +5,7 @@
 
   return array(
     'mimemail_message' => array(
-      'arguments' => array('body' => NULL, 'mailkey' => NULL),
+      'arguments' => array('subject' => NULL, 'body' => NULL, 'mailkey' => NULL, 'recipient' => NULL),
       'template' => 'mimemail-message',
       'pattern' => 'mimemail__',
       'file' => 'mimemail.theme.inc',

@Mac Clemmens: Please open a new issue for your request, $recipient won't get in with this issue.

Attaching a new patch against current HEAD.

Committed to HEAD.