While reviewing this module, I found that the code is formatted extremely consistently, but not in-line with Drupal's coding standards. Could this module be made to follow the standards that the rest of Drupal uses? http://drupal.org/coding-standards

I'd recommend installing the coder module and just running a code-style check on the module and its files. There's not much good in submitting a patch, since it would literally change every line of the entire module.

Comments

justphp’s picture

justphp commented
Assigned: Unassigned » justphp

I use the coder module and it only reports problems with indentation and white space but does not support alternate syntax so do not find it very usable.
I'm not really concerned about code formatting at this stage, I would prefer to add new features, fixes and amends.
Do you have any particular reason for creating this issue, are you editing the moduels code or was just being nosy and checking out the coding?

Personally I find some of the drupal coding standards non-standard, use 2 spaces to indent for example, standard practice is to use 4 spaces, this is what I use and will continue to do so because I'm so used to it, also it would mean changing my editor settings everytime I work on this project, which I'm sure you will agree will make me work less on it due to the amount of pissing about it would entail.

Thanks for your understanding.

quicksketch’s picture

quicksketch
he/him
commented

I'm requesting to follow the standards because it makes submitting patches easier. Since I have my Drupal projects (within Eclipse) all configured to use Drupal coding standards, working on this particular module is troublesome since I need to change the active settings in order to make changes to it. It's true that some things in Drupal are "non-standard" (the tabs and spaces issue being a central one), but none-the-less, everything else in all of Drupal is formatted according to these standards. Having a single format across projects makes it easier for developers to work with each other. It's also true that coder module doesn't support alternative syntax, but that's because the alternative syntax is not the Drupal standard (unless you're working in .tpl.php files).

So basically, following standards makes it easier for me (and other developers) to help with the project.

justphp’s picture

justphp commented
Status: Active » Needs work

Ok, I'll keep this issue open with the aim of eventually converting everything.

quicksketch’s picture

quicksketch
he/him
commented

Thank you, it's very much appreciated!

lizhenry’s picture

lizhenry commented

Well, this is something relatively easy that I could do, maybe better that I start with this rather than the include/exclude functions.

justphp’s picture

justphp commented
Status: Needs work » Closed (won't fix)