The wysiwyg module no longer support any of the versions of whizzywig available for download. Last version supported appear to be 0.56 while current is 0.61 and several things have changed, like WhizzywigToolbar.png no longer used, instead icons.png from 0.60

As the last version (that appear to be) supported no longer is available for download I cannot compare, but in 0.61 the version string is (1st line):
var whizzywig_version='Whizzywig 61';

and the files used are:

whizzywig61.js
icons.png
whizzybrowse3.php

The above files are what is marked as 'featured' and have to be downloaded individually.

I don't have any proper diff tool handy so I put this together by hand, but it's what I did to at least make it recognize whizzywig as installed after renaming whizzywig61.js to whizzywig.js:

whizzywig.inc

about line 30:
      '56' => array(
        'js files' => array('whizzywig-56.js'),
      ),
+      '61' => array(
+        'js files' => array('whizzywig.js'),
+      ),
    ),
  );
  return $editor;

about line 51/54
-  if (preg_match('@Whizzywig v([0-9]+)@', $line, $version)) {
==================
+  if (preg_match('@Whizzywig ([0-9]+)@', $line, $version)) {

about line 79/82
-  if (file_exists($editor['library path'] . '/WhizzywigToolbar.png')) {
-    $settings['toolbarImagePath'] = base_path() . $editor['library path'] . '/WhizzywigToolbar.png';
==================
+  if (file_exists($editor['library path'] . '/icons.png')) {
+    $settings['toolbarImagePath'] = base_path() . $editor['library path'] . '/icons.png';

the n/n above is line start before and after edit. I hope it will be of help and if I find any issue with the editor I'll report it.

/y

Comments

twod’s picture

Version: 6.x-2.1 » 6.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new1.17 KB

Whizzywig 59 available from http://code.google.com/p/whizzywig/downloads/list (linked to from the official Whizzywig Download page) should still be possible to use with Wysiwyg as it seems that no major changes were made between 56 and 59. From 60 and up, the filename and version string has changed though so we need to compensate for that.
Other than that I don't see any changes which affect Wysiwyg.module.

sun’s picture

+++ editors/whizzywig.inc	26 Mar 2010 12:07:49 -0000
@@ -48,7 +48,7 @@ function wysiwyg_whizzywig_version($edit
-  if (preg_match('@Whizzywig v([0-9]+)@', $line, $version)) {
+  if (preg_match('@Whizzywig v?([0-9]+)@', $line, $version)) {

Can we add comment lines here like in ckeditor.inc and tinymce.inc, basically just copying the syntax for the different versions?

+++ editors/whizzywig.inc	26 Mar 2010 12:07:49 -0000
@@ -79,6 +79,9 @@ function wysiwyg_whizzywig_settings($edi
   if (file_exists($editor['library path'] . '/WhizzywigToolbar.png')) {
     $settings['toolbarImagePath'] = base_path() . $editor['library path'] . '/WhizzywigToolbar.png';
   }
+  if (file_exists($editor['library path'] . '/icons.png')) {
+    $settings['toolbarImagePath'] = base_path() . $editor['library path'] . '/icons.png';
+  }

Can we add a short comment here that these are the same + just the filename changed? (ideally with a version pointer, too)

Powered by Dreditor.

twod’s picture

StatusFileSize
new1.3 KB

Maybe I should create the patches after adding the comments and not the other way around hehe.

Edit: Yes I see the trailing space now... how about a standalone version of Dreditor, sun? ;)

sun’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, we can fix the comments prior to commit. :)

sun’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

ep_nl’s picture

hmm, installed the development version, ran update.php just to be sure.
looked at whizzywig.inc to see if the patch was applied, and it was.
however, still get the error message.

what to do?

twod’s picture

Which version of Whizzywig are you using?
I tested the patch with 55i, 56, 59, 60 and 61. Note that the toolbar image was renamed to icons.png and has new buttons for Table operations as of 60.

ep_nl’s picture

hello TwoD,

thanks for your reply. ^^
I'm a little confused now..
When I downloaded Whyzzywig two days ago it said it was latest version 61.
But when I look at the libraries folder it shows whizzywig058.js and whizzywig058.js?
As for the toolbar image, do you mean I should manually rename it to icons.png? In 'my' download it still is called WhizzywigToolbar.png.

Here the files (left out css & gif) in the package whizzywig-6.x-1.4.tar.gz:
root
-- CHANGELOG.txt - 3 K - 01.31.10
-- README.txt - 1 K - 10.26.09
-- whizzywig.module - 34 K - 01.20.10
-- whizzywig.settings.inc - 10 K - 01.31.10
-- LICENSE.txt - 15 K - 04.23.06
-- whizzywig.info - 0 K - 01.31.10
-- whizzywig.png - 16 K - 09.28.09

--library
---- whizzywig058.js - 25 K - 01.17.10
---- whizzywig059.js - 25 K - 12.12.09
---- WhizzywigToolbar.png - 2 K - 09.28.09

ep_nl’s picture

aarrgghh

just downloaded the extra files
whizzywig061.txt and icons.png and put them directly under
sites/all/libraries/whizzywig/
then renamed whizzywig061.txt to whizzywig.js and voila!

Guess the package is meant for a stand-alone whizzywig module, instead of a library for wysisyg.

confused but happy :)

twod’s picture

Yes, that would be the "standalone" Drupal Whizzywig module you had in that .tar.gz. ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

rahim123’s picture

Status: Closed (fixed) » Needs work

Hi,
Sorry, but this is not fixed with whizzywig061. It says "not found" and it gives me a bunch of public-facing warnings.

twod’s picture

Status: Needs work » Postponed (maintainer needs more info)

Are you using the -dev version? The detection should work there.
However, an additional patch is for Whizzywig v60+ to make it work at all in Chrome (Webkit) and behave better when detached. Please see #907186: Whizzywig: v60+ API changes and test the patch provided there.

rahim123’s picture

Thanks for the reply!

Hmm, no, I'm using wysiwyg 6.x-2.1. But my main issue is that I'm not even using Whizzywig on the site that is giving errors. Rather, Site#1 is using Wysiwyg+tinymce, and on Site#2 I just use the Whizzywig module, I don't have the wysiwyg module activated on Site#2. But since I have to put the Whizzywig js file in ~/sites/all/libraries/whizzywig, Site#1 picks up that directory because it's running wysiwyg, and it throws up a bunch of ugly pink warnings to the public site.

I suppose I could upgrade to the dev version, is it reasonably stable? Does it work well with tinymce as well?

Thanks again.

twod’s picture

Status: Postponed (maintainer needs more info) » Fixed

Ah, that's the problem then. Whizzywig has changed quite a bit since Wysiwyg 2.1 was released. If you need to run Whizzywig v60 or v61 I strongly recommend using Wysiwyg 2.x-dev and the patch mentioned in #14. Wysiwyg module is very stable even in -dev versions. The current 2.x-dev has only had code fixes applied to it compared to the 2.1 release, there's no need for an upgrade path and if it doesn't work you can just drop 2.1 back in there.
If you don't want to keep track of patches you can downgrade to Whizzywig v59, it should work out of the box with Wysiwyg 2.x-dev alone in most browsers, Chrome users may not be able to type anything though.

rahim123’s picture

Great, thanks very much for your clear instructions TwoD, very much appreciated!
Have a good one.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

pafla’s picture

I found whizzywig.js at http://www.thegulyaspot.com/site/modules/whizzywig/

Maybe someone can use it, it worked for me.