In filter.admin.inc line 202there is...

  $cache &= !module_invoke($module, 'filter', 'no cache', $delta);

.. which I suggest should be changed to:

  $cache &= !module_invoke($module, 'filter', 'no cache', $delta, $format);

Reason: A filter module may need to decide whether its output should be cacheable or not depending on its own configuration - for example if a feature is configurable in such a way that output may or may not be cacheable depending on the setting. So the filter module needs $format in order to load the relevant version of its configuration and so return its chosen value for 'no cache'.

Patch to follow.

Comments

andy inman’s picture

StatusFileSize
new425 bytes

Patch attached.

sun’s picture

Status: Active » Needs work

Could you please re-roll against CVS + using diff -up ?

andy inman’s picture

Will try, but never done that before, happy to drop to command line CVS but usually use Cervisia which AFAIK won't let me do what your saying. I read http://drupal.org/patch/submit - did I miss something?

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.